2044153 - Switch usage of "browsingContext.fixupAndLoadURIString()" to "browsingContext.loadURI()"

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, task, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Marionette's navigation code uses browsingContext.fixupAndLoadURIString() to trigger the loading of a URL for the WebDriver:NavigateTo command:

https://searchfox.org/firefox-main/rev/e28b34ab33dbf49364999070168cbb7e11e8e5bd/remote/marionette/navigate.sys.mjs#173

Instead we should use browsingContext.loadURI() similar to WebDriver BiDi:

https://searchfox.org/firefox-main/rev/e28b34ab33dbf49364999070168cbb7e11e8e5bd/remote/webdriver-bidi/modules/root/browsingContext.sys.mjs#1392

That way we can feed in a nsIURI and the Toolkit code doesn't have to run the fixup code again.

Comment 1

[Vraj Shah]

Hey, I would like to take on this issue. I am looking to start my open-source contributions specifically in orgs like mozilla as I now stand on a decent experience. I really appreciate your help & trust!

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Hello Vraj. Thanks for showing your interest in this bug. Please take it and get comfortable with our code base. In case of questions feel free to ask here or on Matrix in the https://chat.mozilla.org/#/room/#webdriver:mozilla.org channel.

To get started you can also take a look at https://firefox-source-docs.mozilla.org/remote/index.html.

Comment 3

[tanmay kumar chaurasia]

Hey Vraj, are you working on this issue?

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to tanmay kumar chaurasia from comment #3)

Hey Vraj, are you working on this issue?

Vraj, given that you already asked on bug 2046156 please take that other one instead. Thanks.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Sorry, I think my last comment was confusing. I was not actually asking Vraj to work on the other issue but Tanmay.

Vraj, are you still interested to work on this bug?

Comment 6

[Vraj Shah]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+2] from comment #5)

Sorry, I think my last comment was confusing. I was not actually asking Vraj to work on the other issue but Tanmay.

Vraj, are you still interested to work on this bug?

Yes, i am interested and investigating it, thank you

Comment 7

[Vraj Shah]

Attachment: Bug 2044153 - Switch usage of browsingContext.fixupAndLoadURIString() to browsingContext.loadURI() in Marionette navigateTo. r?whimboo

Comment 8

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Hello Vraj. I would like to get back to you in regards of a requested update of the patch. Maybe you missed those emails or just don't have the time at the moment. Will you be able to continue working on this bug? If not please let us know. Thanks!

Comment 9

[BugBot [:suhaib / :marco]]

Redirect a needinfo that is pending on an inactive user to the triage owner.
:Sasha, since the bug has recent activity, could you have a look please?

For more information, please visit BugBot documentation.

Comment 10

[Alexandra Borovova [:Sasha]]

Looks like Vraj might not have time to continue. I'll clear the assignee so that someone else could pick it up.

Comment 11

[Khalid AlHaddad]

Attachment: Bug 2044153 - Switch usage of "browsingContext.fixupAndLoadURIString()" to "browsingContext.loadURI()" r=whimboo

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0ba87241da92
https://hg.mozilla.org/integration/autoland/rev/a337a4a76fe6
Switch usage of "browsingContext.fixupAndLoadURIString()" to "browsingContext.loadURI()" r=whimboo

Comment 13

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a337a4a76fe6