2044167 - Remove Debugger.onPromiseSettled

Status: RESOLVED FIXED

(Core :: JavaScript: Debugger API, task, P3)

Description

[Bryan Thrall [:bthrall]]

It is not used by the DevTools

Remove:

• Documentation
• Tests
• Implementation

Comment 1

[Riza]

Can I be assigned for this bug?

Comment 2

[Bryan Thrall [:bthrall]]

Riza(In reply to Riza from comment #1)

Can I be assigned for this bug?

Hi Riza! Welcome, and please assign yourself to the bug! If you have any questions, I'm happy to answer them.

Comment 3

[Riza]

Hi Bryan, Thank you and I would like to take this bug. I clicked Edit Bug, but I don't see any way to set myself as the assignee. Could you please assign it to me or let me know how I can do it?(In reply to Bryan Thrall [:bthrall] from comment #2)

Riza(In reply to Riza from comment #1)

Can I be assigned for this bug?

Hi Riza! Welcome, and please assign yourself to the bug! If you have any questions, I'm happy to answer them.

Comment 4

[Jon Coppeard (:jonco)]

I assigned you, but in future there should be a Take button under the People section.

Comment 5

[Riza]

Attachment: 0001-Bug-2044167-Remove-Debugger.onPromiseSettled.patch

This patch removes Debugger.onPromiseSettled from the Debugger API, removes its implementation and call sites, updates documentation, and removes related tests.

Comment 6

[Bryan Thrall [:bthrall]]

:Riza, we currently use Phabricator to review patches. Would you please resubmit the patch following these instructions?

Comment 7

[Riza]

Attachment: Bug 2044167 - Remove Debugger.onPromiseSettled

Comment 8

[Riza]

(In reply to Bryan Thrall [:bthrall] from comment #6)

:Riza, we currently use Phabricator to review patches. Would you please resubmit the patch following these instructions?

Thanks! I have resubmitted the patch through Phabricator as requested (D309543).

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3b7a5d5dc963
https://hg.mozilla.org/integration/autoland/rev/9dbafd10e96f
Remove Debugger.onPromiseSettled r=bthrall

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b75e60794d6b
https://hg.mozilla.org/integration/autoland/rev/97acad6a226d
Revert "Bug 2044167 - Remove Debugger.onPromiseSettled r=bthrall" for causing build bustages

Comment 11

[rperta]

Backed out for causing build bustages
Backout link
Push with failures
Failure log(s)

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f29e48f0a2de
https://hg.mozilla.org/integration/autoland/rev/f1de2266f7be
Remove Debugger.onPromiseSettled r=bthrall

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a3e54f59ec1f
https://hg.mozilla.org/integration/autoland/rev/9e10c5b2894e
Revert "Bug 2044167 - Remove Debugger.onPromiseSettled r=bthrall" for causing failures on bug-1505622.js

Comment 14

[Cosmin Sabou [:CosminS]]

Backed out for causing failures on bug-1505622.js

Push with failures

Failure log

Backout link

Comment 15

[Bryan Thrall [:bthrall]]

I'm looking into the cause of the bug-1505622.js failures. It shouldn't be related to the changes for this bug, but I don't know what is going on there yet.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ec6217e7e80f
https://hg.mozilla.org/integration/autoland/rev/b91d1981bbf4
Remove Debugger.onPromiseSettled r=bthrall

Comment 17

[Bryan Thrall [:bthrall]]

I think the failure on push on 7/9 was due to other, unrelated patches. bug-1505622.js is working just fine on asan builds now with this bug's patches.

Comment 18

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b91d1981bbf4