2044297 - Mispositioned urlbar when using search engine

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Emilio Cobos Álvarez [:emilio]]

Attachment: Example

The urlbar is mispositioned when using the keyboard to launch a custom search engine. I see this in the last couple days.

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Simpler STR:

• Clean profile.
• Type @wiki then press tab.

Mozregression points to bug 2040188.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

[Tracking Requested - why for this release]: Very visual regression on the urlbar

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 2040188

Comment 4

[Daisuke Akatsuka (:daisuke)]

Thank you very much, Emilio!
I will take a look.

Comment 5

[Drew Willcoxon :adw]

Related to bug 2041255?

Comment 6

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 2044297 - Set Proton's breakout-extend whenever the view is open

This restores the original Proton behavior.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/75e2fa931543
https://hg.mozilla.org/integration/autoland/rev/3751c3a96404
Set Proton's breakout-extend whenever the view is open r=adw

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5c9a1ee0e801
https://hg.mozilla.org/integration/autoland/rev/76444077230c
Revert "Bug 2044297 - Set Proton's breakout-extend whenever the view is open r=adw" for causing bc failures at browser_UITour3.js

Comment 9

[Silaghi Andreea]

Backed out for causing bc failures at browser_UITour3.js
Backout Link
Push with failures
Failure Log
Failure line TEST-UNEXPECTED-FAIL | browser/components/uitour/test/browser_UITour3.js | test_info_buttons_1 - popuphidden event did not happen within 5 seconds.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The bug is marked as tracked for firefox153 (nightly). However, the bug still has low severity.

:cbellini, could you please increase the severity for this tracked bug? If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 12

[Drew Willcoxon :adw]

Bug 2040188 affects 152 and we'll need to uplift its fix, so I'll mark this bug as affecting 152 too.

Also, the additional problem pointed out in bug 2040188 comment 15 is fixed by the patch in this bug.

Comment 13

[Drew Willcoxon :adw]

[Tracking Requested - why for this release]: Obvious visual regression in the urlbar tightly related to bug 2040188.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bf4c3717dfb4
https://hg.mozilla.org/integration/autoland/rev/6fa37e2199f6
Set Proton's breakout-extend whenever the view is open r=adw,omc-reviewers,emcminn

Comment 15

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 2044297 - Set Proton's breakout-extend whenever the view is open

This restores the original Proton behavior.

Original Revision: https://phabricator.services.mozilla.com/D304316

Comment 16

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: The urlbar position will be shifted a bit if showing empty result.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: This fixes only the position of the urlbar for Proton.
• String changes made/needed?: None
• Is Android affected?: unknown

Comment 17

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/6fa37e2199f6

Comment 18

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/3551ce65c749
https://hg.mozilla.org/releases/mozilla-beta/rev/c94c76ab32df

Comment 19

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2026-06-02 Firefox Nightly build on Windows 10, using the STR from Comment 1.

Verified as fixed on Firefox Nightly 153.0a1 and Firefox 152.0b9 (treeherder build) on Windows 10, Ubuntu 22, macOS 13.