2044479 - Extract interface for ContentAnalysis "backend"

Status: RESOLVED FIXED

(Enterprise Products :: Firefox, enhancement, P1)

Description

[jmendez]

The existing DLP support in Firefox uses the Content Analysis SDK to connect at various action hooks to an external agent that is the DLP engine. We want to re-use the existing infrastructure for DLP hooks, but allow using our built-in DLP engine depending on policy configuration. To enable cleanly choosing between an external agent or the built-in engine, we should extract an interface so each mode will have its implementation.

Comment 1

[jmendez]

Attachment: Bug 2044479 - Part 1: Add interface for content analysis backend r=gstoll!

Comment 2

[jmendez]

Attachment: Bug 2044479 - Part 2: Add skeleton ExternalAgentBackend wired into ContentAnalysis r=gstoll!

Comment 3

[jmendez]

Attachment: Bug 2044479 - Part 3: Move ContentAnalysis SDK communication logic to ExternalAgentBackend class r=gstoll!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/092322ac0a94
https://hg.mozilla.org/integration/autoland/rev/845284018c46
Part 1: Add interface for content analysis backend r=gstoll
https://github.com/mozilla-firefox/firefox/commit/07436981bba7
https://hg.mozilla.org/integration/autoland/rev/4aa4ba58f3a9
Part 2: Add skeleton ExternalAgentBackend wired into ContentAnalysis r=gstoll
https://github.com/mozilla-firefox/firefox/commit/ba958d51ede1
https://hg.mozilla.org/integration/autoland/rev/71ce6a869362
Part 3: Move ContentAnalysis SDK communication logic to ExternalAgentBackend class r=gstoll

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c9c3e622847c
https://hg.mozilla.org/integration/autoland/rev/6aecf382985d
Revert "Bug 2044479 - Part 3: Move ContentAnalysis SDK communication logic to ExternalAgentBackend class r=gstoll" for causing build bustages @ExternalAgentBackend.cpp.

Comment 6

[agoloman]

Backed out for causing build bustages @ExternalAgentBackend.cpp.

• Backout link
• Push with failures
• Failure Log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/14f3594ae2f2
https://hg.mozilla.org/integration/autoland/rev/27fa76f75671
Part 1: Add interface for content analysis backend r=gstoll
https://github.com/mozilla-firefox/firefox/commit/a07a181d0e65
https://hg.mozilla.org/integration/autoland/rev/3f039ac71631
Part 2: Add skeleton ExternalAgentBackend wired into ContentAnalysis r=gstoll
https://github.com/mozilla-firefox/firefox/commit/47ccc89b3625
https://hg.mozilla.org/integration/autoland/rev/bc1a9e880513
Part 3: Move ContentAnalysis SDK communication logic to ExternalAgentBackend class r=gstoll

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/27fa76f75671
https://hg.mozilla.org/mozilla-central/rev/3f039ac71631
https://hg.mozilla.org/mozilla-central/rev/bc1a9e880513