2044483 - World Clocks widget is missing the widgets.clocks.interaction pref and interaction tracking entirely

Status: RESOLVED FIXED

(Firefox :: New Tab Page, defect, P2)

Description

[Maxx Crawford [:maxx]]

Issue:

Every other New Tab widget tracks user engagement via a widgets.<widget>.interaction pref, set through handleUserInteraction(widgetName) in Widgets.jsx. Prefs exist for lists, focusTimer, weatherForecast, and sportsWidget (defined in lib/ActivityStream.sys.mjs).

The World Clocks widget has none of this:

• There is no widgets.clocks.interaction pref.
• Clocks.jsx / ClocksRow.jsx / AddClockForm.jsx never call handleUserInteraction, even though Widgets.jsx already passes it to the widget as a prop.

As a result, we have no engagement signal for Clocks, and it's inconsistent with the
other widgets.

What to do:

1. Add a widgets.clocks.interaction pref alongside the others in lib/ActivityStream.sys.mjs.
2. Wire handleUserInteraction("clocks") into the genuine interactions in Clocks.jsx, following the rule established in bug 2044456: every interaction flips it except "Hide widget."
3. Add unit tests asserting each of those flips the pref and that hide does not.

Candidate handlers:

• handleToggleHourFormat,
• handleChangeSize,
• handleLearnMore,
• handleShowAddClock,
• handleShowEditClocks,
• handleSaveClock (add/edit),
• handleRemoveClock.

Acceptance criteria:
Interacting with the Clocks widget (e.g. adding a clock, toggling 12/24h, resizing) sets browser.newtabpage.activity-stream.widgets.clocks.interaction to true; hiding it does not.

Comment 1

[japandi]

Attachment: Bug 2044483 - Add widgets.clocks.interaction pref and wire up handleUserInteraction in Clocks widget. r=maxx

Comment 2

[Maxx Crawford [:maxx]]

Attachment: Bug 2044483 - Remove ClocksRowWidget registry wrapper so handleUserInteraction is wired up r?#home-newtab-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/997f3ff86514
https://hg.mozilla.org/integration/autoland/rev/9d2dc76b9e2b
Add widgets.clocks.interaction pref and wire up handleUserInteraction in Clocks widget. r=maxx
https://github.com/mozilla-firefox/firefox/commit/972d30e09e46
https://hg.mozilla.org/integration/autoland/rev/6d0a38daea8d
Remove ClocksRowWidget registry wrapper so handleUserInteraction is wired up r=thecount

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e715aa69e0d6
https://hg.mozilla.org/integration/autoland/rev/85848fb2b334
Revert "Bug 2044483 - Remove ClocksRowWidget registry wrapper so handleUserInteraction is wired up r=thecount" for causing failures at Clocks.test.jsx

Comment 5

[Atila Butkovits]

Backed out for causing failures at Clocks.test.jsx

Backout link: https://hg.mozilla.org/integration/autoland/rev/85848fb2b334

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=6d0a38daea8dc5c4c91aac72385ae96d7768bd91&selectedTaskRun=OkqCjpLdQbm8Au3N5M9jrA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=579989666&repo=autoland&task=OkqCjpLdQbm8Au3N5M9jrA.0&lineNumber=3089

Comment 6

[japandi]

Hi, how can I bring this to your attention that the patch got reverted for failing tests.

Comment 7

[Maxx Crawford [:maxx]]

japandi - If you can rebase the stack again (be sure to use --reapply-cherry-picks) and I can rebase and can push again. Thanks!

Comment 8

[japandi]

Done !!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/730ccf4a28cc
https://hg.mozilla.org/integration/autoland/rev/e0eac6f3e57b
Add widgets.clocks.interaction pref and wire up handleUserInteraction in Clocks widget. r=maxx
https://github.com/mozilla-firefox/firefox/commit/f113afb6cb48
https://hg.mozilla.org/integration/autoland/rev/d675cc2d709f
Remove ClocksRowWidget registry wrapper so handleUserInteraction is wired up r=thecount

Comment 10

[rperta]

https://hg.mozilla.org/mozilla-central/rev/e0eac6f3e57b
https://hg.mozilla.org/mozilla-central/rev/d675cc2d709f