Closed Bug 2044499 Opened 1 month ago Closed 4 days ago

Add HW support plumbing to RemoteDecoderModule::Supports result

Categories

(Core :: Audio/Video, task, P2)

Product:
Core
Component:
Audio/Video
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
154 Branch
Tracking Flags:
Tracking Status
firefox153 --- affected
firefox154 --- fixed

People

(Reporter: pehrsons, Assigned: pehrsons, NeedInfo)

References

(Blocks 2 open bugs)

Details

Attachments

(2 files)

Bug 2044499 - Add plumbing for HW support to RemoteDecoderModule. r=media-playback-reviewers,alwu
48 bytes, text/x-phabricator-request
Details | Review
Bug 2044499 - Add plumbing for HW support to RemoteDecoderModule.
48 bytes, text/x-phabricator-request
Details | Review

There is an r+ patch which didn't land and no activity in this bug for 1 week.
:pehrsons, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(apehrson)
Flags: needinfo?(alwu)
Flags: needinfo?(apehrson)
Flags: needinfo?(alwu)
Pushed by pehrsons@gmail.com: https://github.com/mozilla-firefox/firefox/commit/d1eb911aebc1 https://hg.mozilla.org/integration/autoland/rev/e2c17816f739 Add plumbing for HW support to RemoteDecoderModule. r=media-playback-reviewers,alwu
Attachment #9603299 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: Improves accuracy of results for the new webrtc MediaCapabilities path added in bug 2032075, mainly on Android.
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: no
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: Trivial; simply stops masking the codec support set that was reported from a remote process.
  • String changes made/needed?: None
  • Is Android affected?: yes

https://hg.mozilla.org/mozilla-central/rev/e2c17816f739

Status: ASSIGNED → RESOLVED
Closed: 19 days ago
status-firefox154: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
Attachment #9603299 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Pushed by asilaghi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/7b2fa32c6272 https://hg.mozilla.org/integration/autoland/rev/2cf2684bc495 Revert "Bug 2044499 - Add plumbing for HW support to RemoteDecoderModule. r=media-playback-reviewers,alwu" at dev request for causing Bug 2052237

[Tracking Requested - why for this release]:

Status: RESOLVED → REOPENED
status-firefox154: fixed → affected
tracking-firefox154: --- → ?
Resolution: FIXED → ---
Target Milestone: 154 Branch → ---
Flags: needinfo?(azebrowski)
Depends on: 2052237
Attachment #9603299 - Flags: approval-mozilla-beta+
Depends on: 2055061
Regressions: 2055061
Pushed by ktomlinson@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/2a5dd3ea03d2 https://hg.mozilla.org/integration/autoland/rev/917f63165e79 Add plumbing for HW support to RemoteDecoderModule. r=media-playback-reviewers,alwu

Odd, I never (meant to) set the regression flag

No longer regressions: 2055061
Pushed by imoraru@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/20ff417cc538 https://hg.mozilla.org/integration/autoland/rev/9bbf7fbb0c8c Revert "Bug 2044499 - Add plumbing for HW support to RemoteDecoderModule. r=media-playback-reviewers,alwu" for causing wpt failures on decodingInfo-webrtc-power-efficient.any.html.

Revert for causing wpt failures on decodingInfo-webrtc-power-efficient.any.html.

Flags: needinfo?(karlt)
Attachment #9593603 - Attachment description: Bug 2044499 - Add plumbing for HW support to RemoteDecoderModule. → Bug 2044499 - Add plumbing for HW support to RemoteDecoderModule. r=media-playback-reviewers,alwu
Pushed by ktomlinson@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/1dedfe73ad7d https://hg.mozilla.org/integration/autoland/rev/aeb06b5bd54c Add plumbing for HW support to RemoteDecoderModule. r=media-playback-reviewers,alwu

https://hg.mozilla.org/mozilla-central/rev/aeb06b5bd54c

Status: REOPENED → RESOLVED
Closed: 19 days ago → 4 days ago
status-firefox154: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
Flags: needinfo?(karlt)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: