Closed Bug 2044514 Opened 5 months ago Closed 5 months ago

Thunderbird build broken due to inclusion of unused function

Categories

(Core :: Widget: Win32, defect)

defect

Tracking

()

RESOLVED FIXED
153 Branch
Tracking Status
firefox-esr140 --- unaffected
firefox151 --- unaffected
firefox152 --- fixed
firefox153 --- fixed

People

(Reporter: sking, Assigned: darktrojan)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 external files)

Thunderbird builds are broken by regressor with unused function message. (toolkit/xre/nsAppRunner.cpp(2373,13): error: unused function 'SetupSkeletonUIPrefs' [-Werror,-Wunused-function] )
logs: https://treeherder.mozilla.org/logviewer?job_id=570327855&repo=comm-central&task=A1bny9UpQYGU_t1Um3ZLfQ.0&lineNumber=69670

Assignee: nobody → geoff
Status: NEW → ASSIGNED

Set release status flags based on info from the regressing bug 2010302

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Attachment #9595826 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: Thunderbuild windows builds are broken due to previous uplift of regressor
  • Code covered by automated testing?: no
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing: n/a
  • Risk associated with taking this patch: low
  • Explanation of risk level: This bug simple removed a function that is unused during Thunderbird builds using guards.
  • String changes made/needed?: none
  • Is Android affected?: no
Attachment #9595826 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: