Closed
Bug 2044514
Opened 5 months ago
Closed 5 months ago
Thunderbird build broken due to inclusion of unused function
Categories
(Core :: Widget: Win32, defect)
Core
Widget: Win32
Tracking
()
RESOLVED
FIXED
153 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr140 | --- | unaffected |
| firefox151 | --- | unaffected |
| firefox152 | --- | fixed |
| firefox153 | --- | fixed |
People
(Reporter: sking, Assigned: darktrojan)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 external files)
Thunderbird builds are broken by regressor with unused function message. (toolkit/xre/nsAppRunner.cpp(2373,13): error: unused function 'SetupSkeletonUIPrefs' [-Werror,-Wunused-function] )
logs: https://treeherder.mozilla.org/logviewer?job_id=570327855&repo=comm-central&task=A1bny9UpQYGU_t1Um3ZLfQ.0&lineNumber=69670
| Assignee | ||
Updated•5 months ago
|
Assignee: nobody → geoff
Status: NEW → ASSIGNED
| Assignee | ||
Comment 1•5 months ago
|
||
Comment 2•5 months ago
|
||
Set release status flags based on info from the regressing bug 2010302
status-firefox151:
--- → unaffected
status-firefox152:
--- → unaffected
status-firefox153:
--- → affected
status-firefox-esr140:
--- → unaffected
Pushed by geoff@darktrojan.net:
https://github.com/mozilla-firefox/firefox/commit/7a9f0cbd4f66
https://hg.mozilla.org/integration/autoland/rev/c7816c95012f
Compile SetupSkeletonUIPrefs conditionally. r=win-reviewers,handyman
Comment 4•5 months ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
| Comment hidden (Intermittent Failures Robot) |
| Reporter | ||
Comment 6•5 months ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D304307
Updated•5 months ago
|
Attachment #9595826 -
Flags: approval-mozilla-beta?
Comment 7•5 months ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined/Reason for urgency: Thunderbuild windows builds are broken due to previous uplift of regressor
- Code covered by automated testing?: no
- Fix verified in Nightly?: yes
- Needs manual QE testing?: no
- Steps to reproduce for manual QE testing: n/a
- Risk associated with taking this patch: low
- Explanation of risk level: This bug simple removed a function that is unused during Thunderbird builds using guards.
- String changes made/needed?: none
- Is Android affected?: no
Updated•5 months ago
|
Attachment #9595826 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•5 months ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•