2044589 - [macOS] Exclude non-notarized geckodriver builds from the Taskcluster index

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task, P3)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

At the moment we have two kinds of geckodriver builds indexed for macOS in the Taskcluster index:
https://firefox-ci-tc.services.mozilla.com/tasks/index/gecko.v2.mozilla-central.revision.253b8523586577438a3ddf86d67436719feaf6d8.geckodriver/

macosx64
macosx64-notarized

Given that we only want to ship the notarized binaries of geckodriver we should not add the non-notarized binaries, but only add the notarized ones as macosx64.

Note that those builds are now universal binaries as well, so not sure if the x64 suffix still applies, or if we should name it macos.

Andrew, what do you think about the naming?

Comment 1

[Andrew Halberstadt [:ahal]]

Doesn't matter too much to me! If you don't care about the un-notarized builds, you could just make macosx64 point at the notarization task instead. Or maybe call it macosx64-shippable to it can be consistent across platforms.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 2044589 - [geckodriver] Only add the notarized macOS builds to the Taskcluster index.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Andrew Halberstadt [:ahal] from comment #1)

Doesn't matter too much to me! If you don't care about the un-notarized builds, you could just make macosx64 point at the notarization task instead. Or maybe call it macosx64-shippable to it can be consistent across platforms.

Thanks. I think what I might have to do is to not index the signed builds for macOS, but only for Linux and Windows. And then in the notarization task for geckodriver on macOS I can index it as macosx64.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/17a81fecda35
https://hg.mozilla.org/integration/autoland/rev/ac1239ea6e30
[geckodriver] Only add the notarized macOS builds to the Taskcluster index. r=taskgraph-reviewers,releng-reviewers,ahal

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/ac1239ea6e30

Comment 6

[Julian Descottes [:jdescottes]]

(I assume that was meant to be m21)

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

I just noticed that the latest indexed geckodriver files in Taskcluster still include outdated folder names:

https://firefox-ci-tc.services.mozilla.com/tasks/index/gecko.v2.mozilla-central.latest.geckodriver

macosx64 was correctly updated about 10 hours ago. However, macosx64-notarized, which I removed here, is still listed and was last updated 3 days ago. In addition, macosx64-aarch64 and macosx64-aarch64-notarized are no longer valid, because since bug 2028933 we ship universal geckodriver builds. How can we get those folders removed from the 'latest' index? Ben, could you help with that? Thanks!

Comment 8

[Julien Cristau [:jcristau]]

They'll disappear when the indexed tasks expire.

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to Julien Cristau [:jcristau] from comment #8)

They'll disappear when the indexed tasks expire.

Thanks. As per task defintion this should happen in about 10 months. So still a bit to carry it along.