2044602 - [css-text-decor-4] Allow percentages in `text-decoration-inset`

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Mozilla Apprentice]

A resolution was made for csswg-drafts/#8403.

[css-text-decor-4] Allow percentages in `text-decoration-inset`

• RESOLVED: add %s, and they resolve on either sum of segments or individual segments depending on b-d-b

Discussion.

Comment 1

[Boris Chiou [:boris]]

So I guess the resolution makes the syntax of text-decoration-inset as

<length-percentage>{1,2} | auto 

Extend <length> to <length-percentage>, and resolve the percentage part depending on box-decoration-break property.

Comment 2

[Boris Chiou [:boris]]

Attachment: Bug 2044602 - Parse <lenght-percentage> for text-decoration-inset.

We add an extra preference,
layout.css.text-decoration-inset-percentage.enabled, for the support of
percentage. This patch only implements the syntax and parsing. We still
have to resolve the percentage part in the following patches.

Also, add the missing parsing tests in WPT.

Comment 3

[Boris Chiou [:boris]]

Attachment: Bug 2044602 - Resolve the percentage value of text-decoration-inset.

We resolve the percentage based on the resolutino of the spec issue [1].

Per the spec issue, if we specify box-decoration-break:slice, we have to
use the total length of all breaks as the basis. If the property value
is clone, each fragment is considered individually.

[1] https://github.com/w3c/csswg-drafts/issues/8403

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/782d5f393d77
https://hg.mozilla.org/integration/autoland/rev/d1d225400bfc
Parse <lenght-percentage> for text-decoration-inset. r=firefox-style-system-reviewers,layout-reviewers,emilio
https://github.com/mozilla-firefox/firefox/commit/f50d8fe9e4ca
https://hg.mozilla.org/integration/autoland/rev/136735908f74
Resolve the percentage value of text-decoration-inset. r=layout-reviewers,emilio

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/60940 for changes under testing/web-platform/tests

Comment 6

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/d1d225400bfc
https://hg.mozilla.org/mozilla-central/rev/136735908f74

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot

Comment 8

[Dave Letorey]

Related pull requests

• Content PR
• Firefox Release PR
• Data PR

Comment 9

[Sebastian Zartner [:sebo]]

It seems there wasn't an Intent to Prototype or Ship sent out for the general support of text-decoration-inset, nor a standards position for it.

Maybe there should be one sent out now?

Also note that Google just sent out their Intent to Ship (including percentages).

Sebastian

Comment 10

[Boris Chiou [:boris]]

(In reply to Sebastian Zartner [:sebo] from comment #9)

It seems there wasn't an Intent to Prototype or Ship sent out for the general support of text-decoration-inset, nor a standards position for it.

Maybe there should be one sent out now?

Also note that Google just sent out their Intent to Ship (including percentages).

Sebastian

Just sent out. Thanks for the reminder.
https://groups.google.com/a/mozilla.org/g/dev-platform/c/pMeTxjoOx1o