2044651 - Generate QR code… option is available when multiple tabs are selected if accessed from File > Share or url bar context menu

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Attachment: image.png

Notes

• Please refer to the attached screenshot for more details.
• The option is greyed out if accessed from the tab context menu.
• The same behavior can be observed on macOS if accessing the option from the address bar context menu.
• The option will generate the QR code for whichever tab is active.

Found in

• Nightly 153.0a1;

Affected versions

• Nightly 153.0a1;

Tested platforms

• Ubuntu 22;
• Windows 10;
• macOS 15;

Affected platforms

• macOS 15;
• Ubuntu 22;
• Windows 10;

Unaffected platforms

• N/A;

Steps to reproduce

1. Launch Firefox.
2. Open 2 or more websites in different tabs and select them.
3. Press Alt key to enable Menu Bar.
4. Click on File -> Share -> Generate QR code…

Expected result

• Generate QR code… option should be greyed out.

Actual result

• Generate QR code option is available.

Regression range

• Not a regression.

Comment 1

[Andrew Overholt [:overholt]]

Attachment: Bug 2044651 - Pass the full tab selection to the File and address bar Share menus. r?#sharing-reviewers

Comment 3

[Andrew Overholt [:overholt]]

It's worth noting that when multiple tabs are selected, right-clicking on the multiple selected tabs results in a disabled Share > QR code menu entry.

Misha, what do you think we should do here? I see three options to handle the File > Share and right-click-on-URL-bar cases:

1. disable the menu item when multiple tabs are selected in these two situations (File > Share and right-click-on-URL-bar )
2. generate a QR code for each selected tab, having them read when the user goes to each one (since only the foreground tab will have it visible)
3. leave things as-is, where a QR code is generated and shown in a dialog for the foreground tab and nothing happens on background tabs.

Comment 4

[misha [:mbruk]]

Thanks for laying out your thoughts. I think option 1 is the cleanest.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/36492ab7f78f
https://hg.mozilla.org/integration/autoland/rev/ca00c14de7c0
Pass the full tab selection to the File and address bar Share menus. r=sharing-reviewers,urlbar-reviewers,jhirsch,hsohaney,Standard8

Comment 6

[amarc]

https://hg.mozilla.org/mozilla-central/rev/ca00c14de7c0

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:overholt, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox153 to wontfix.

For more information, please visit BugBot documentation.

Comment 8

[Andrew Overholt [:overholt]]

Uplift requested.

Comment 9

[Andrew Overholt [:overholt]]

Attachment: Bug 2044651 - Pass the full tab selection to the File and address bar Share menus.

Original Revision: https://phabricator.services.mozilla.com/D304861

Comment 10

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Minor UX bug
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: QE found this. On macOS, in addition to right-clicking on the tab, there are 2 additional entry points for sharing QR codes: 1. File > Share and 2. right-click on URL bar. When multiple tabs are selected, Share > Generate QR Code... should be disabled in all 3 cases but without this patch, the File > Share and right-click-on-URL-bar cases show it.
• Risk associated with taking this patch: low
• Explanation of risk level: This is a new feature, has automated tests, and can be turned off via a pref if things go poorly.
• String changes made/needed?: no
• Is Android affected?: no

Comment 11

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/48f57b31111e
https://hg.mozilla.org/releases/mozilla-beta/rev/df9126e85950

Comment 12

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Issue is verified as fixed on Firefox Nightly 154.0a1 and Firefox 153.0b6 on Windows 10, Ubuntu 22, macOS 13.