Closed
Bug 2044749
Opened 2 months ago
Closed 2 months ago
Expose code suggestions in the feed.for_email.query inline comments API
Categories
(Conduit :: Phabricator, enhancement)
Conduit
Phabricator
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: padenot, Assigned: padenot)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
The feed.for_email.query API exposes inline comments on Differential revisions, but does not include code suggestion data (hasSuggestion / suggestionText). This means consumers of the API cannot access or act on reviewer-provided code suggestions.
This patch adds hasSuggestion (bool) and suggestionText (string) fields to the EmailInlineComment model, populated from the inline comment's content state via newInlineCommentObject()->getContentState().
|
||
Comment 1•2 months ago
|
||
|
||
Updated•2 months ago
|
Assignee: nobody → padenot
|
|
||
Comment 2•2 months ago
|
||
Authored by https://github.com/padenot
https://github.com/mozilla-conduit/phabricator/commit/39516d7762016b68c21e9b35e8ab35e97ac7f634
[master] Bug 2044749 - Expose code suggestions in feed.for_email.query inline comments
Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•