2044798 - Non-functional code in queueEngineWarmup

Status: VERIFIED FIXED

(Firefox for Android :: General, defect)

Description

[Markus Stange [:mstange]]

I made a mistake in D277473 (from bug 2023004) which means that queueEngineWarmup is a no-op.

We already have a patch to fix it in D295868; I'm filing this bug to land it.

Comment 1

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2023004

Comment 2

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 2044798 - Fix syntax error in `FenixApplication.kt` by removing an unnecessary trailing brace in `queueEngineWarmup`.

Key changes:

• Corrected the queueEngineWarmup function signature by removing an extra set of braces that incorrectly wrapped the runOnVisualCompleteness call.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5742c635a8f7
https://hg.mozilla.org/integration/autoland/rev/7f3a52c08876
Fix syntax error in `FenixApplication.kt` by removing an unnecessary trailing brace in `queueEngineWarmup`. r=android-reviewers,jonalmeida

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ff4699c68bb7
https://hg.mozilla.org/integration/autoland/rev/bcac479b8b7d
Revert "Bug 2044798 - Fix syntax error in `FenixApplication.kt` by removing an unnecessary trailing brace in `queueEngineWarmup`. r=android-reviewers,jonalmeida" for causing failures at openMultipleSelectedBookmarksInANewTabTest.

Comment 5

[Atila Butkovits]

Backed out for causing failures at openMultipleSelectedBookmarksInANewTabTest.

Backout link: https://hg.mozilla.org/integration/autoland/rev/bcac479b8b7d

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=7f3a52c0887631642af620fc16ea62da1b4ab3df&selectedTaskRun=JkbG8ajFRhuFQUBgyqwfOA.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=570710804&repo=autoland&task=JkbG8ajFRhuFQUBgyqwfOA.0&lineNumber=326

Comment 6

[Aaron Train [:aaronmt]]

A bit of a bizarre downstream effect (either unexpected or expected change now) is that this test uses a local server and the expected title we check for on tabs is different from before. The tab titles now appear as opposed to their previous full localhost URL. Perhaps related to engine warm-up and when that resolves?

In any case if that's expected now, this line just needs updating to reflect that if expected https://searchfox.org/firefox-main/source/mobile/android/fenix/app/src/androidTest/java/org/mozilla/fenix/ui/BookmarksTest.kt#181

Comment 7

[Aaron Train [:aaronmt]]

Attachment: before.png

Comment 8

[Aaron Train [:aaronmt]]

Attachment: after.png

Comment 9

[Mihai Adrian Carare [:mcarare]]

I would say the the page title is what is expected to be seen there, the URL would be just a fallback.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/486d7d0f339b
https://hg.mozilla.org/integration/autoland/rev/47c8e3aa7988
Fix syntax error in `FenixApplication.kt` by removing an unnecessary trailing brace in `queueEngineWarmup`. r=android-reviewers,jonalmeida

Comment 11

[Aaron Train [:aaronmt]]

Thanks. For posterity: the stray braces on queueEngineWarmup made it return an uninvoked lambda instead of running its body, so engine.warmUp() never executed (w/o visual-completeness queue as intended).

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/47c8e3aa7988

Comment 13

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:mcarare, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox152 to wontfix.

For more information, please visit BugBot documentation.

Comment 14

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: engine warm-up not triggered
• Code covered by automated testing?: no
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: We are fixing a regression, putting things as they were before the patch that introduced the change.
• String changes made/needed?: No.
• Is Android affected?: yes

Comment 15

[Mihai Adrian Carare [:mcarare]]

Attachment: Bug 2044798 - Fix syntax error in `FenixApplication.kt` by removing an unnecessary trailing brace in `queueEngineWarmup`.

Key changes:

• Corrected the queueEngineWarmup function signature by removing an extra set of braces that incorrectly wrapped the runOnVisualCompleteness call.

Original Revision: https://phabricator.services.mozilla.com/D295868

Comment 16

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/4b697e678c64
https://hg.mozilla.org/releases/mozilla-beta/rev/e86be4c38f7d

Comment 17

[Adina Petridean QA [:apetridean]]

Attachment: Screenshot_20260609_095226_One UI Home.jpg

Verified as fixed on the latest Nightly 153.0a1 -from 08.06.2026 and Beta 152.0b9 with Lenovo Yoga Tab 11 (Android 12) and Samsung Galaxy S25( Android 15).