Closed Bug 2044825 Opened 1 month ago Closed 1 month ago

Remove borders for location buttons in locations subview

Categories

(Firefox :: IP Protection, task)

task

Tracking

()

VERIFIED FIXED
153 Branch
Tracking Status
firefox153 --- verified
firefox154 --- verified

People

(Reporter: kpatenio, Assigned: kpatenio)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fx-vpn])

Attachments

(2 files)

Figma: https://www.figma.com/design/O5gPSsJAkI5fxiRxReO8El/Built-in-VPN-Firefox-152?node-id=15271-8122&m=dev
Nova spec: https://www.figma.com/design/O5gPSsJAkI5fxiRxReO8El/Built-in-VPN-Firefox-152?node-id=15150-14095&m=dev

I received confirmation from UX that we ultimately want the borders removed from the location buttons when HCM or a contrast theme is set.

The borders are added in https://searchfox.org/firefox-main/rev/6301b01791f9c98637ae8d5b7a81dd004d48d468/browser/components/ipprotection/content/locations-subview.css#69-75 when prefers-contrast or forced-colors is enabled. Removing these rules will undo the borders.

Assignee: nobody → kpatenio
Status: NEW → ASSIGNED
Attachment #9593791 - Attachment description: WIP: Bug 2044825 — remove borders for HCM in locations subview → Bug 2044825 — remove borders for HCM in locations subview
Pushed by agoloman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/3d957aa72702 https://hg.mozilla.org/mozilla-central/rev/e840e66bd9cc — remove borders for HCM in locations subview r=ip-protection-reviewers,rking
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED

Verified this as fixed using Firefox Nightly 154.0a1 and Firefox Beta 153.0b1 on macOS 26/Windows 11.
The borders for HCM/Increase contrast in locations subview were removed.

QA Whiteboard: [qa-triage-done-c154/b153]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: