2044855 - List All Tabs tab group rows in current window have broken context menus

Status: NEW

(Firefox :: Tabbed Browser: Tab Groups, defect)

Description

[Stephen Thompson [:sthompson]]

STR

1. Create a tab group with a few tabs
2. Open the List All Tabs menu
3. In the "Current window" section, right-click the row representing the tab group

Expected results:

• Context menu opens without errors
• Choosing a menu item from the context item works

Actual results:

• Uncaught TypeError: can't access property "ownerDocument", tabGroup is null in main-popupset.js:601 when right-clicking the row
• Uncaught TypeError: can't access property "documentGlobal", tabGroup is null in main-popupset.js:161 when choosing an option like "Move Group to New Window"

Root cause:
When I fixed bug 1954346 I made TabsList set a "tab-group-id" attribute on group rows instead of setting a data-tab-group-id attribute https://searchfox.org/firefox-main/rev/6301b01791f9c98637ae8d5b7a81dd004d48d468/browser/components/tabbrowser/TabsList.sys.mjs#590. However, GroupsList and main-popupset continue to expect data-tab-group-id, so right-clicking tab group rows in the tab groups list in List All Tabs continues to work. This bug was not caught because the automated tests only exercise the context menu on groups in the group list, not group rows in the tabs list.

I think these should all use the same contract. Note that tab-groups-list.mjs now also uses these tab group context menus and GroupsList is intended to be deleted at some point. Open tab groups in the tabs list of List All Tabs should also have the open tab group context menu exercised in an automated test.

Comment 1

[BugBot [:suhaib / :marco]]

The severity field is not set for this bug.
:jswinarton, could you have a look please?

For more information, please visit BugBot documentation.