2045094 - [Tab Groups] Tab groups aren't always displayed when first created

Status: VERIFIED FIXED

(Firefox for Android :: Tabs, defect)

Description

[Noah Bond [:007]]

About 1/10 times, when creating your first tab group, the group will get created but NOT displayed. Instead, the tab manager will display a stale state of no tab groups in the tab grid/list. When this occurs, the tab group page will either show the tab group with zero tabs, or it will not display any tab groups at all.

Comment 1

[Noah Bond [:007]]

Pairing with Julie, we found that there was a race condition with how the data was being emitted from the database, where the tab group metadata and the tab group's list of tab IDs were emitting separately and would overlap each other when creating the UI data model.

We found that having one Flow emitting all of the data instead of two Flows emitting the data separately solves this issue.

Comment 2

[Noah Bond [:007]]

Attachment: Bug 2045094 - Fix bug causing tab groups to not always display when first created

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f47b84de71e4
https://hg.mozilla.org/integration/autoland/rev/36432fc2b14c
Fix bug causing tab groups to not always display when first created r=android-reviewers,jdelorenzo

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/36432fc2b14c

Comment 5

[Mira Lobontiu (Android QA)]

Reproduced the issue with a Vivo V23 (Android 14) device on RC 152 Firefox for Android.

Comment 6

[BugBot [:suhaib / :marco]]

The patch landed in nightly and 152 is affected.
:007, is this bug important enough to require an uplift?

• If yes, please nominate the patch for Release approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox152 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Mira Lobontiu (Android QA)]

Verified on the latest Firefox for Android Nightly 153.0a1 from 6/11 using a Vivo v23 (Android 14), and a Pixel 6 (Android 17).

Comment 8

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: A subset of users will have a degraded experience, perceiving the app/feature is broken during the first interaction with creating a tab group.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: Create a tab group via drag and drop (or multiselection)

Delete the tab group and try again, if the group is created

• Risk associated with taking this patch: medium
• Explanation of risk level: The risk touches how tab group data is read-in from the database. The scope of changes is small, but it involves a core code area.

This change has been baking in Nightly and 153 beta, and it's been verified in Nightly.

• String changes made/needed?: N/A
• Is Android affected?: yes

Comment 9

[Noah Bond [:007]]

Attachment: Bug 2045094 - Fix bug causing tab groups to not always display when first created

This required changing the Tab Group repo to emit one Flow instead of one per data model (one for group meta data and one for tab group assignments). This was a bit of a jenga block change, and it required some structural changes to our tests and repo code.

This also introduces two new data models:

• TabGroupData
  • This is the new data class wrapper for everything being emitted from the repo.
• TabGroup
  • This is a new data class so the underlying database model does not have to leak through the codebase.

Some repo operations were also removed if they were only being used inside of tests.

This patch also fixes a typo with the tab group assignment data model.

Original Differential Revision: https://phabricator.services.mozilla.com/D305413

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/bf48f76a59cb
https://hg.mozilla.org/releases/mozilla-release/rev/e2458060548a

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Added to the 152.0.2 relnotes.

Comment 12

[Mira Lobontiu (Android QA)]

Verified on the latest Firefox for Android 152.0.2 version, using a Samsung Galaxy S24 (Android 16), and a Pixel 6 (Android 17).