2045124 - Gate smart_window_user_feedback_data to primary button submit event only

Status: VERIFIED FIXED

(Core :: Machine Learning: Frontend, task)

Description

[echa]

The user-facing disclaimer states that feedback data and metadata are shared when the user submits the report. However, smart_window_user_feedback_data is currently attached to all telemetry emitted from the feedback modal. Update the telemetry flow to only include smart_window_user_feedback_data when source === "primary_button" && event === "CLICK_BUTTON"

Comment 1

[echa]

Attachment: Bug 2045124 - Gate smart_window_user_feedback_data to primary button submit event only r?pdahiya

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/76b04a65d5a7
https://hg.mozilla.org/integration/autoland/rev/906e298e0b97
Gate smart_window_user_feedback_data to primary button submit event only r=pdahiya,omc-reviewers,aminomancer

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/906e298e0b97

Comment 4

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: The Smart Window feedback form disclaimer states that feedback data and metadata are shared when the user submits the report. However, smart_window_user_feedback_data is currently attached to all telemetry emitted from the feedback modal. This patch updates the telemetry flow to only include smart_window_user_feedback_data when user submits
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: - Open Smart Window and start chat
• Click thumbs up/down on assistant response
• ensure metadata is not recorded
• Risk associated with taking this patch: low
• Explanation of risk level: Low - this patch only adds extra checks before setting feedbackData
• String changes made/needed?: No
• Is Android affected?: yes

Comment 5

[echa]

Attachment: Bug 2045124 - Gate smart_window_user_feedback_data to primary button submit event only

Original Revision: https://phabricator.services.mozilla.com/D304900

Comment 6

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/0a057cfe4856
https://hg.mozilla.org/releases/mozilla-beta/rev/880440930a49

Comment 7

[Rares Doghi, Desktop QA]

Hi @Elissa, whenever I click the Thumbs UP/ Thumbs down feedback and the modal shows up, I will get the following telemetry :

"microsurvey.event_context": "{"screen_family":"SMARTWINDOW_FEEDBACK_MODAL_POSITIVE","screen_index":0,"screen_id":"SMARTWINDOW_FEEDBACK_SCREEN","screen_initials":"F","page":"spotlight"}",
"microsurvey.event_screen_id": "SMARTWINDOW_FEEDBACK_SCREEN",
"microsurvey.message_id": "SMARTWINDOW_FEEDBACK_MODAL_POSITIVE_0_SMARTWINDOW_FEEDBACK_SCREEN_F",
"microsurvey.event_screen_family": "SMARTWINDOW_FEEDBACK_MODAL_POSITIVE",
"microsurvey.event_screen_initials": "F"

Is this ok ? or should this only show up after we hit the Submit button from the modal ?

Which telemetry data should only show up after we hit the Submit button ?

Comment 8

[echa]

Hi Rares! Yes that looks fine - previously when the feedback button was clicked the event would also include metadata like prompt version, model, and turn count but it looks like it's not showing up here.

Comment 9

[Rares Doghi, Desktop QA]

Verified as fixed in our latest Beta 152.0b9 and our latest Nightly 153.0a1 (2026-06-08)