2045219 - Improve the dump result of `nsINode`

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, task)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

The current result is not enough for me and its reference cannot be used with fmt::format directly.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 2045219 - Improve the debug print of `nsINode` r=smaug!,#dom-core

Currently, operator<<(std::ostram&, const nsINode&) prints the path
of the node with some attribute information of each node. However, there
are some issues:

1. It's unclear if the reached root is a DocumentFragment or
   ShadowRoot due to the same node name, #document-fragment.
2. Do not print the host's path.
3. Cannot print only in a specific node such as a contenteditable.
4. It's hard to consider which Text if a node has multiple Text
   nodes.
5. No information about the assigned <slot>.
6. No information about EditContext.

This patch appends these information to each node. Additionally, adding
format_as() for avoiding to use mozilla::ToString for fmt::format
and MOZ_LOG_FMT.

Finally, to test the new data, this makes Selection and SelectionAPI
log use MOZ_LOG_FMT.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/821c05533a2b
https://hg.mozilla.org/integration/autoland/rev/290c377062c6
Improve the debug print of `nsINode` r=smaug,dom-core-reviewers

Comment 3

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/290c377062c6