2045353 - For functions that take `already_AddRefed<T>&&`, change to `already_AddRefed<T>` (pass by value instead of by rvalue reference), to force an ownership-transfer into the function (in security/sandbox/)

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, task)

Description

[Daniel Holbert [:dholbert]]

See bug 2044510 comment 0 for explanation/justification.

This bug is about some test code in security/sandbox/, for some pieces that I originally had lumped into https://phabricator.services.mozilla.com/D304376 but am now spinning off to this followup so that the already-reviewed bulk of the patch stack in bug 2044510 can land.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 2045353: Pass already_AddRefed types by-value instead of by rvalue reference, in SandboxTesting code. r?bobowen

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/add4a61e530e
https://hg.mozilla.org/integration/autoland/rev/ace1e79af9c9
Pass already_AddRefed types by-value instead of by rvalue reference, in SandboxTesting code. r=bobowen

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/ace1e79af9c9