When printing long format listings of bug lists, the alias should be included.
Created attachment 124394 [details] [diff] [review] add bug alias to the long listing This patch puts the alias, if it exists, in square brackets after the bug id
Comment on attachment 124394 [details] [diff] [review] add bug alias to the long listing zach: are we bumping template versions yet? A nit on the IFNULL... why not just use '' instead of having to backslash the double-quotes? From what I've seen MySQL tends to prefer single-quotes anyway.
I was meaning to clarify about the template version updating in the newsgroup. I was just going on the Bugzilla Developers Guide regarding templates, which says: > Every template shipped with Bugzilla has a version number on the first line such as > firstname.lastname@example.org. You should update this when you edit a template. > You need to increment the major part if your updates make the interface to this template > incompatible with the interface of previous versions. Otherwise, you need to increment the > minor part.
Created attachment 127972 [details] [diff] [review] Add alias to long format bug list patch 2 Without the template version change and nit fixed.
Comment on attachment 127972 [details] [diff] [review] Add alias to long format bug list patch 2 >Index: template/en/default/bug/show-multiple.html.tmpl >+ [% IF Param("usebugaliases") %] >+ [% IF bug.alias != "" %] Nits: * second conditional should be indented additional two spaces; * second conditional can be simply [% IF bug.alias %]; * conditionals can be combined [% IF Param("...") AND bug.alias %]. >+ [ [% bug.alias FILTER html %] ] Nits: * curly braces (()); * no space between the braces and the alias. All problems are nits, so r=myk, but consider the nits before opting to check in current patch.
Attachment #127972 - Flags: review+
Comment on attachment 124394 [details] [diff] [review] add bug alias to the long listing Removing unneeded review requests.
Created attachment 129189 [details] [diff] [review] add alias to long listing patch 3 Patch 3, fixing Myk's nits. I can't commit, so if the review is carried over to this patch, could someone commit this please?
Comment on attachment 129189 [details] [diff] [review] add alias to long listing patch 3 This patch fails to apply; I had to apply by hand. Did you hand-edit this patch by any chance? In any case, the code itself works fine. r=myk
Attachment #129189 - Flags: review?(myk) → review+
Created attachment 129195 [details] [diff] [review] patch v3 with patch problems corrected This patch is like patch #3 except that it applies correctly.
Attachment #129189 - Attachment is obsolete: true
Checking in long_list.cgi; /cvsroot/mozilla/webtools/bugzilla/long_list.cgi,v <-- long_list.cgi new revision: 1.36; previous revision: 1.35 done Checking in template/en/default/bug/show-multiple.html.tmpl; /cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/show-multiple.html.tmpl,v <-- show-multiple.html.tmpl new revision: 1.12; previous revision: 1.11 done
Oops, forgot to mark fixed.
Status: NEW → RESOLVED
Last Resolved: 16 years ago
Resolution: --- → FIXED
Target Milestone: --- → Bugzilla 2.18
You need to log in before you can comment on or make changes to this bug.