Validate (IPC) ClientInfo
Categories
(Core :: DOM: Networking, enhancement, P2)
Tracking
()
People
(Reporter: tschuster, Assigned: tschuster)
References
(Blocks 1 open bug)
Details
(Keywords: sec-want, Whiteboard: [necko-triaged][necko-priority-queue][adv-main154-][adv-esr153.1-])
Attachments
(4 external files, 2 obsolete files)
The IPCClientInfo contains security critical information. We should at least verify the principal every time it is send across IPC. The agentClusterId looks like another candidate for verification.
IPCClientInfo is used by multiple APIs, such as fetch, Workers or WebTransport.
| Assignee | ||
Updated•5 months ago
|
Comment 1•5 months ago
|
||
Updated•5 months ago
|
Comment 2•5 months ago
|
||
Comment on attachment 9595136 [details]
(secure)
Revision D305279 was moved to bug 2045783. Setting attachment 9595136 [details] to obsolete.
Comment 3•5 months ago
|
||
Comment 4•5 months ago
|
||
Updated•5 months ago
|
Comment 5•4 months ago
|
||
| Assignee | ||
Comment 6•4 months ago
|
||
I kind of lost track of this and started working on very similar and related checks in bug 2018164. Jesup: I wouldn't mind taking over these patches from you and merge in a few of the bits from my patch.
Updated•4 months ago
|
| Assignee | ||
Comment 7•4 months ago
|
||
Stealing this.
Comment 9•3 months ago
|
||
Updated•3 months ago
|
| Assignee | ||
Comment 10•3 months ago
|
||
Not sure yet about ESR140. If we uplift this we probably should/need to uplift bug 2018164 and bug 2052883 at least.
Comment 11•3 months ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined/Reason for urgency: sec-moderate that is blocking other security bugs.
- Code covered by automated testing?: yes
- Fix verified in Nightly?: yes
- Needs manual QE testing?: no
- Steps to reproduce for manual QE testing:
- Risk associated with taking this patch: medium
- Explanation of risk level: Principal validation in a few places that might crash the child process if we forgot about some edge case.
- String changes made/needed?: no
- Is Android affected?: yes
| Assignee | ||
Comment 12•3 months ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D305382
Comment 13•3 months ago
|
||
firefox-esr153 Uplift Approval Request
- User impact if declined/Reason for urgency: sec-moderate that is blocking other security bugs.
- Code covered by automated testing?: yes
- Fix verified in Nightly?: yes
- Needs manual QE testing?: no
- Steps to reproduce for manual QE testing:
- Risk associated with taking this patch: medium
- Explanation of risk level: Principal validation in a few places that might crash the child process if we forgot about some edge case.
- String changes made/needed?: no
- Is Android affected?: yes
| Assignee | ||
Comment 14•3 months ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D305382
Updated•3 months ago
|
Updated•3 months ago
|
Comment 15•3 months ago
|
||
| uplift | ||
Updated•3 months ago
|
Updated•3 months ago
|
Updated•3 months ago
|
Comment 16•3 months ago
|
||
| uplift | ||
Updated•3 months ago
|
Updated•3 months ago
|
Updated•3 months ago
|
Updated•3 months ago
|
Updated•21 days ago
|
Description
•