Closed Bug 2045721 Opened 5 months ago Closed 3 months ago

Validate (IPC) ClientInfo

Categories

(Core :: DOM: Networking, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
155 Branch
Tracking Status
firefox-esr115 --- wontfix
firefox-esr140 --- wontfix
firefox-esr153 154+ fixed
firefox153 --- wontfix
firefox154 + fixed
firefox155 + fixed

People

(Reporter: tschuster, Assigned: tschuster)

References

(Blocks 1 open bug)

Details

(Keywords: sec-want, Whiteboard: [necko-triaged][necko-priority-queue][adv-main154-][adv-esr153.1-])

Attachments

(4 external files, 2 obsolete files)

The IPCClientInfo contains security critical information. We should at least verify the principal every time it is send across IPC. The agentClusterId looks like another candidate for verification.

IPCClientInfo is used by multiple APIs, such as fetch, Workers or WebTransport.

Component: DOM: Security → DOM: Networking
Attached file (secure) (obsolete) —
Assignee: nobody → rjesup
Status: NEW → ASSIGNED

Comment on attachment 9595136 [details]
(secure)

Revision D305279 was moved to bug 2045783. Setting attachment 9595136 [details] to obsolete.

Attachment #9595136 - Attachment is obsolete: true
Attached file (secure) (obsolete) —
Severity: -- → S3
Priority: -- → P2
Whiteboard: [necko-triaged][necko-priority-queue]
Blocks: 2018164
Blocks: 2024537

I kind of lost track of this and started working on very similar and related checks in bug 2018164. Jesup: I wouldn't mind taking over these patches from you and merge in a few of the bits from my patch.

Flags: needinfo?(rjesup)
Attachment #9595296 - Attachment is obsolete: true

Stealing this.

Assignee: rjesup → tschuster
Flags: needinfo?(rjesup)
Pushed by tschuster@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/bccde97888d6 https://hg.mozilla.org/integration/autoland/rev/1e172828bb12 Add IPCClientInfo type checking r=necko-reviewers,ipc-reviewers,dom-worker-reviewers,nika,asuth,valentin
Group: network-core-security → core-security-release
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 155 Branch

Not sure yet about ESR140. If we uplift this we probably should/need to uplift bug 2018164 and bug 2052883 at least.

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: sec-moderate that is blocking other security bugs.
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: medium
  • Explanation of risk level: Principal validation in a few places that might crash the child process if we forgot about some edge case.
  • String changes made/needed?: no
  • Is Android affected?: yes
Attachment #9618200 - Flags: approval-mozilla-beta?
Attached file (secure) —

firefox-esr153 Uplift Approval Request

  • User impact if declined/Reason for urgency: sec-moderate that is blocking other security bugs.
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: medium
  • Explanation of risk level: Principal validation in a few places that might crash the child process if we forgot about some edge case.
  • String changes made/needed?: no
  • Is Android affected?: yes
Attachment #9618201 - Flags: approval-mozilla-esr153?
Attached file (secure) —
Attachment #9618200 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
QA Whiteboard: [sec] [uplift] [qa-triage-done-c155/b154]
Attachment #9618201 - Flags: approval-mozilla-esr153? → approval-mozilla-esr153+
Blocks: 2046769
Whiteboard: [necko-triaged][necko-priority-queue] → [necko-triaged][necko-priority-queue][adv-main154-]
Whiteboard: [necko-triaged][necko-priority-queue][adv-main154-] → [necko-triaged][necko-priority-queue][adv-main154-][adv-esr153.1-]
Group: core-security-release
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: