2045734 - Switching Search Engine After a Query Has Already Been Searched Creates a New Tab

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Roger Yang [:royang]]

When a user searches for a query and then chooses a different search engine from the toolbar to search for again, Firefox Android opens the new search in a separate tab.

This is a behavioural change from the non-composable toolbar implementation.

Comment 1

[Denys [:denyshon]]

Just a note that the new search query may not match the previous one, and that shouldn't change the behavior.

Comment 2

[Denys [:denyshon]]

Another note: you don't even have to search the second time. Even entering a URL after switching search engines will open a new tab instead of overriding the existing one

Comment 3

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 2045734 - Ensure changing search engine does not reset initial search parameters r=#android-reviewers

Previously when changing search engines through the unified search selector
we'd start a fresh new search.
After these changes the starting point of the initial search will be kept
in toolbar's state.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0e3e27a3e6a1
https://hg.mozilla.org/integration/autoland/rev/07420bbcaf23
Ensure changing search engine does not reset initial search parameters r=android-reviewers,Roger

Comment 5

[rperta]

https://hg.mozilla.org/mozilla-central/rev/07420bbcaf23