Closed Bug 2045886 Opened 5 months ago Closed 5 months ago

Display selected tab in sidebar open tabs panel when Nova is enabled

Categories

(Firefox :: Sidebar, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
154 Branch
Tracking Status
firefox154 --- fixed

People

(Reporter: nsharpley, Assigned: dr.seed.lu, Mentored)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fidefe-sidebar][outreachy-sidebar-2026])

Attachments

(1 file, 1 external file)

When browser.nova.enabled is true, we display a selected tab in the tab strip with a gradient border. We should do the same for the sidebar open tabs panel when Nova is enabled. Gradient implementation found here: https://searchfox.org/firefox-main/rev/89a0d289f40c328d85ec105574f5e7d34fd9846d/browser/themes/shared/tabbrowser/tabs.css#921-931

Priority: -- → P3

This adds the gradient border to the active tab in the sidebar Open Tabs
panel when browser.nova.enabled is true, matching the tab strip.

Each sidebar-tab-row watches its own tab's selected attribute with a
MutationObserver and sets a current attribute when its tab is the
active one.

This is needed because OpenTabs.sys.mjs treats TabSelect as
a TabRecencyChange, not a TabChange, so the panel's existing TabChange
listener does not pick up tab switches. Rows in the other sidebar panels
do not receive a tab element and are unaffected.

Assignee: nobody → dr.seed.lu
Status: NEW → ASSIGNED
Attachment #9598136 - Attachment description: Bug 2045886 - Display selected tab in sidebar open tabs panel when Nova is enabled r?nsharpley,kcochrane → Bug 2045886 - Display selected tab in sidebar open tabs panel when Nova is enabled r?kcochrane
Pushed by kcochrane@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/08953e8ebfa0 https://hg.mozilla.org/integration/autoland/rev/6d1c93585587 Display selected tab in sidebar open tabs panel when Nova is enabled r=kcochrane,desktop-theme-reviewers
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
QA Whiteboard: [qa-triage-done-c155/b154]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: