Closed Bug 2045958 Opened 5 months ago Closed 4 months ago

Investigate return value handling in ForOfDisposalEmitter::prepareForForOfIteratorClose

Categories

(Core :: JavaScript Engine, defect, P3)

defect

Tracking

()

RESOLVED FIXED
154 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr140 --- unaffected
firefox-esr153 --- wontfix
firefox152 --- wontfix
firefox153 --- wontfix
firefox154 --- fixed

People

(Reporter: jandem, Assigned: arai)

References

(Blocks 2 open bugs)

Details

(Keywords: sec-other, Whiteboard: [adv-main154-])

Attachments

(1 external file)

Spinning this off from bug 2045957 so the other bug can focus on the uninitialized memory read.

arai, can you look into the bytecode RVAL issue reported in bug 2045957? This is the root cause but I think it becomes just a correctness bug if we make the JIT rval-slot handling more robust.

Flags: needinfo?(arai.unmht)
Keywords: sec-other

So, this is similar to bug 2023369's case, in the different code path.
That sounds like, we should put the GetRval/SetRval pair in more common/shared code path and let all consumers use it whenever await happens in the possibly-leaving code.

Flags: needinfo?(arai.unmht)
Severity: -- → S3
Priority: -- → P3
Attached file (secure) —
Assignee: nobody → arai.unmht
Status: NEW → ASSIGNED
Group: javascript-core-security → core-security-release
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
QA Whiteboard: [qa-triage-done-c155/b154][sec]
Flags: qe-verify+
Whiteboard: [adv-main154-]
Group: core-security-release
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: