Closed Bug 2045978 Opened 3 days ago Closed 19 hours ago

[wpt-sync] Sync PR 60488 - [ruby-overhang] Fix crash when computing overhang without an open tag

Categories

(Core :: Layout: Ruby, task, P4)

Product:
Core
Component:
Layout: Ruby
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
153 Branch
Tracking Flags:
Tracking Status
firefox153 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 60488 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/60488
Details from upstream follow.

Minseong Kim <jja08111@gmail.com> wrote:

[ruby-overhang] Fix crash when computing overhang without an open tag

Fuzzer found a crash that occurs during ruby-overhang calculations when
the layout engine makes a ruby that doesn't have a preceding open tag in
its inline items.

So, this CL replaces the DCHECK with a guarding if ruby_index is zero in
GetOverhang.

Bug: 520181855
Change-Id: I1f6d460f12c24aadac5e6e5fb052d0a1e68af346

Reviewed-on: https://chromium-review.googlesource.com/7902135
WPT-Export-Revision: 8979b1b1fbfd4dbc6928b6d4b2d14debe0735634

Component: web-platform-tests → Layout: Ruby
Product: Testing → Core

CI Results

Ran 11 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 164 tests

Status Summary

Firefox

OK : 20
PASS: 1[GitHub] 5[Gecko-linux2204-64-wayland-debug, Gecko-linux2204-64-wayland-opt] 78[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 174[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL: 14[Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt] 57[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]

Chrome

PASS: 1

Safari

PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/4586bd918bef https://hg.mozilla.org/integration/autoland/rev/a7194145da7e [wpt PR 60488] - [ruby-overhang] Fix crash when computing overhang without an open tag, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a7194145da7e

Status: NEW → RESOLVED
Closed: 19 hours ago
status-firefox153: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
You need to log in before you can comment on or make changes to this bug.