Closed Bug 2045981 Opened 3 days ago Closed 1 day ago

[wpt-sync] Sync PR 60489 - Reland "[Connection-Allowlist] Enforce for speculation rules prerender"

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox153 fixed)

RESOLVED FIXED
153 Branch
Tracking Status
firefox153 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 60489 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/60489
Details from upstream follow.

Xiaochen Zhou <xiaochenzh@chromium.org> wrote:

Reland "[Connection-Allowlist] Enforce for speculation rules prerender"

This is a reland of commit 68d975aadb2878c61da2ed0174be429fe19cebd0

The test fails on Android builder because on Android feature
IsPrerender2FallbackPrefetchSpecRulesEnabled is disabled. There is no
prefetch ahead of the prerender. So the prerender request is made and
gets blocked by the connection allowlist. Its error code should be
UNSAFE_REDIRECT instead of ERR_ABORTED, which is the error code for
feature enabled case.

Original change's description:

[Connection-Allowlist] Enforce for speculation rules prerender

  • The prerendering navigation request already correctly sets the
    initiator frame token. The Connection Allowlist(CA) check in navigation
    request enforces according to the initiator frame's CA.
  • Add browser test and WPT.
  • Add browser test for kPrerender2FallbackPrefetchSpecRules feature.
    When enabled, a fallback prefetch request is created for speculation
    rules prerender. The fallback prefetch is also checked by CA.

About CA: https://github.com/WICG/connection-allowlists

Bug: 447954811, 492462315
Change-Id: I3f14f25d03c9d72eec5a652246769b6e4be36cae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7886514
Reviewed-by: Andrew Verge \<averge@chromium.org>
Commit-Queue: Xiaochen Zhou \<xiaochenzh@chromium.org>
Reviewed-by: Takashi Toyoshima \<toyoshim@chromium.org>
Reviewed-by: Lingqi Chi \<lingqi@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1642470}

Bug: 447954811, 492462315, 521162817
Cq-Include-Trybots: luci.chromium.try:android-14-arm64-rel,android-arm64-rel
Change-Id: I14fd7db06338ff4cee0a58e045e6404d9e0e83d0

Reviewed-on: https://chromium-review.googlesource.com/7907724
WPT-Export-Revision: a8d31e33553dddae54046ae5e2efe13af0db8132

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 54 tests and 5 subtests

Status Summary

Firefox

OK : 49[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 52[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
PASS : 94[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 97[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
FAIL : 169[Gecko-android-em-14-x86_64-debug-geckoview] 170[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview] 181[Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt]
TIMEOUT: 2[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt, GitHub] 3[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]
ERROR : 1
NOTRUN : 5[Gecko-android-em-14-x86_64-debug-geckoview, Gecko-linux2404-64-debug, Gecko-linux2404-64-opt, Gecko-windows11-32-25h2-debug, Gecko-windows11-32-25h2-opt, Gecko-windows11-64-25h2-debug, Gecko-windows11-64-25h2-opt, GitHub] 8[Gecko-android-em-14-x86_64-lite-opt-geckoview, Gecko-android-em-14-x86_64-opt-geckoview]

Chrome

OK : 1
PASS : 2
FAIL : 4

Safari

TIMEOUT: 2
NOTRUN : 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Status: NEW → RESOLVED
Closed: 1 day ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
You need to log in before you can comment on or make changes to this bug.