Closed Bug 2046148 Opened 5 months ago Closed 5 months ago

Sports widget: show an "Extra time" label beside the clock for live matches in extra time

Categories

(Firefox for Android :: Homepage, defect)

All
Android
defect

Tracking

()

VERIFIED FIXED
153 Branch
Tracking Status
firefox152 --- verified
firefox153 --- verified

People

(Reporter: skhan, Assigned: skhan)

References

Details

(Whiteboard: [fxdroid][group3][world-cup-phase2])

Attachments

(1 file, 2 external files)

When a match is live and in extra time, the featured match card should label it. We now show an "Extra time" string immediately to the left of the live clock (e.g. "Extra time 120'"), and mirror it in the card's content description for screen readers.

A live match is treated as in extra time when its period denotes extra time -- the feed uses both "ET" and "Extra" (case-insensitively), matched via the String.isExtraTime extension in SportCardData.kt.

Implemented in MatchCard.kt (Scoreboard + matchBodyMiddleText); reuses the existing sports_widget_extra_time string (no longer marked UnusedResources).

The feed labels a live match's extra-time period with either "ET" or "Extra"
(case-insensitively), but String.isExtraTime only matched an exact "Extra". Widen
it to a case-insensitive substring match on either form so the "Extra time" label
shows for both.

Assignee: nobody → skhan
Status: NEW → ASSIGNED
Pushed by skhan@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/28be65a9c1f1 https://hg.mozilla.org/integration/autoland/rev/7d07357b2776 Match both "ET" and "Extra" period strings as extra time in the sports widget r=android-reviewers,moyin
Type: enhancement → defect
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch

The feed labels a live match's extra-time period with either "ET" or "Extra"
(case-insensitively), but String.isExtraTime only matched an exact "Extra". Widen
it to a case-insensitive substring match on either form so the "Extra time" label
shows for both.

Original Revision: https://phabricator.services.mozilla.com/D305663

Attachment #9595937 - Flags: approval-mozilla-beta?

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: During the 2026 World Cup, live knockout matches in extra time aren't labelled in the sports widget — users see only the clock with no extra-time indicator. The first patch adds the "Extra time" label; the second ensures it triggers for the feed's "ET" period value (not just "Extra"). Time-sensitive: the tournament is in progress.
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: yes
  • Steps to reproduce for manual QE testing: Steps: with the debug drawer's mock World Cup server, set a live match's period to "ET", then "Extra", then "ExtraTime"; confirm the "Extra time" label appears beside the clock on the featured match card in each case.
  • Risk associated with taking this patch: low
  • Explanation of risk level: Scoped entirely to the Fenix sports-widget extra-time label. The first patch adds a concatenated "Extra time: {clock}" label for live matches in extra time; the second widens a pure string predicate from an exact "Extra" match to a case-insensitive substring match on "ET"/"Extra" (strictly broadens what already matched). Nothing outside the widget is affected.
  • String changes made/needed?: None
  • Is Android affected?: yes
Flags: qe-verify+
Attachment #9595937 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

This issue is verified as fixed on Firefox for Android Nightly 153 (2026-06-10) and Firefox 152 RC under under Oppo Find X3 Neo (Android 11) and Samsung S24 Ultra (Android 16). Confirming that "Extra time" label appears beside the clock for a live game.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: