2046153 - Enable link-parameters on Nightly

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, task)

Comment 1

[Tyler Thrailkill [:snowe]]

Attachment: Bug 2046153 - Enable link-parameters in Nightly r=#firefox-style-system-reviewers,#layout-reviewers,emilio

Comment 2

[Tyler Thrailkill [:snowe]]

Enabled in nightly.

Comment 3

[Sebastian Zartner [:sebo]]

For the release notes request, see https://bugzilla.mozilla.org/show_bug.cgi?id=2022783#c40.

Sebastian

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/37971dcd986e
https://hg.mozilla.org/integration/autoland/rev/e81e97166abc
Enable link-parameters in Nightly r=emilio,firefox-style-system-reviewers,layout-reviewers

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/e81e97166abc

Comment 6

[Dave Letorey]

I have been doing some testing on this to see that works according to the spec.
I built this pen

Using the link-parameters CSS property seems to be working as expected.

Using <img src="https://assets.codepen.io/5342839/rainbow.svg#param(--circle8, white)" alt="grey-arch" /> to add param() to the image src does. not work as expected

Using background-image: url("https://assets.codepen.io/5342839/rainbow.svg", param(--circle8, green)); does not work as expected

Have these last 2 been implemented?

I have tested this in Firefox Nightly 154

Comment 7

[Tyler Thrailkill [:snowe]]

No, only link-parameters with svgs was implemented. Work still needs to be done for images and URLs

Comment 8

[Pascal Chevrel (relman team) -> :pascalc]

Note added to our 153 & 154 nightly release notes in the Web Platform section with this wording:

Starting with Firefox 153, Firefox Nightly ships an experimental implementation of the link-parameters property by Tyler Thrailkill.

Comment 9

[Dave Letorey]

I am assuming that setting env() with custom-properties is not supported either?
https://drafts.csswg.org/css-link-params/#example-d60cfbe7

Comment 10

[Dave Letorey]

Should the env() function work on all attribute on all SVG elements
I have tried, using the env() function on the dur & repeatCount attributes of the <animate> SVG element

https://codepen.io/CodeRedDigital/pen/BypZoQv

<svg viewBox="0 0 10 10" xmlns="http://www.w3.org/2000/svg">
  <rect width="10" height="10">
    <animate
      attributeName="rx"
      values="0;5;0"
      dur="env(--breath-speed, 5s)"
      repeatCount="env(--breath-count, 2)" />
  </rect>
</svg>

Comment 11

[Tyler Thrailkill [:snowe]]

Hmm. I'm not aware of a reason it shouldn't work. I will investigate and add tests for those attributes.

Comment 12

[Dave Letorey]

Related issues and pull requests

• Content PR
• BCD PR
• Associated BCD PR
• Data PR
• Firefox Release PR

Comment 13

[Donal Meehan [:dmeehan]]

Removing the nightly-only note since the release note has been carried over for 3 cycles.
A final release note can be added and tracked under the bug that eventually enables this.