2046237 - [wpt-sync] Sync PR 60501 - [HiC] Add AnimatedImageFrameIndexMap to CanvasChildPaintState

Status: RESOLVED FIXED

(Core :: Graphics: Canvas2D, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 60501 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/60501
Details from upstream follow.

Stefan Zager <[e-mail]> wrote:

[HiC] Add AnimatedImageFrameIndexMap to CanvasChildPaintState

When serializing/rasterizing the canvas, we use CustomDataOps bookended
around the element image drawPicture call to ensure that animated image
frame indices are resolved by the map from the drawn element image.
The upshot is that the frame index is pinned to whatever the current
frame index was when the paint snapshot was taken.

This also makes animated images work for worker thread canvas.

Bug: 435220195
Change-Id: I604e2d3fd7863f2f3e1cda69cd0481a2f89ad723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7901732
Reviewed-by: Philip Rogers \<[e-mail]>
Reviewed-by: Dave Tapuska \<[e-mail]>
Reviewed-by: Kai Ninomiya \<[e-mail]>
Reviewed-by: Vladimir Levin \<[e-mail]>
Commit-Queue: Stefan Zager \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1644086}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=62d5272bcb632c1caacecead1db19a9e69095d8c

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

TIMEOUT: 4

Chrome

TIMEOUT: 4

Safari

TIMEOUT: 4

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/canvas/element/manual/draw-element-image/animated-gif-pinned-to-element-image.tentative.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
  • Canvas.drawElementImage: animated gif advances and repaints the canvas: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
• /html/canvas/offscreen/manual/draw-element-image/animated-gif-worker.tentative.html [wpt.fyi]: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)
  • Canvas.drawElementImage: animated gif in worker: TIMEOUT (Chrome: TIMEOUT, Safari: TIMEOUT)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7d709a52ca2c
https://hg.mozilla.org/integration/autoland/rev/36c7201e2644
[wpt PR 60501] - [HiC] Add AnimatedImageFrameIndexMap to CanvasChildPaintState, a=testonly
https://github.com/mozilla-firefox/firefox/commit/cb1f63569034
https://hg.mozilla.org/integration/autoland/rev/f6f71bcb39df
[wpt PR 60501] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/36c7201e2644
https://hg.mozilla.org/mozilla-central/rev/f6f71bcb39df