Closed Bug 2046594 Opened 18 days ago Closed 3 days ago

Include Small size widgets in the "Maximize" action when in the widget row

Categories

(Firefox :: New Tab Page, task)

Product:
Firefox
Component:
New Tab Page
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
154 Branch
Tracking Flags:
Tracking Status
firefox154 --- fixed

People

(Reporter: dgrant, Assigned: dgrant)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 2046594 - Include small in-row widgets in the widgets-row Maximize action.
48 bytes, text/x-phabricator-request
Details | Review
No description provided.
Assignee: nobody → dgrant
Status: NEW → ASSIGNED

The widgets-row Maximize/Minimize toggle skipped every widget at "small",
on the assumption a small widget always lives in the sidebar. A small widget
rendered in the row was therefore left behind when maximizing. Skip only
widgets actually in the sidebar (hasSidebar && size === "small"), matching
WidgetsSidebar and weatherGoesToSidebar.

Attachment #9596288 - Attachment description: WIP: Bug 2046594 - Include small in-row widgets in the widgets-row Maximize action. → Bug 2046594 - Include small in-row widgets in the widgets-row Maximize action.
Pushed by dgrant@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/62feafcaa1dc https://hg.mozilla.org/integration/autoland/rev/966a89589c49 Include small in-row widgets in the widgets-row Maximize action. r=reemhamz

https://hg.mozilla.org/mozilla-central/rev/966a89589c49

Status: ASSIGNED → RESOLVED
Closed: 3 days ago
status-firefox154: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: