2046696 - Swiping vertically in search results can open the tabs tray

Status: VERIFIED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[Petru-Mugurel Lingurar [:petru]]

Attachment: Swiping up in awesomebar opens tabs tray.mp4

Steps to reproduce

1. ensure "Swipe toolbar vertically to see open tabs" is enabled in Settings -> Customize
2. ensure the toolbar is shown at the bottom of the screen
3. do a search
4. tap on the search item to update the original search
5. Swipe up in search results (not in the toolbar)

Expected behavior

The keyboard closes

Actual behavior

The tabs tray is opened

Comment 1

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 2046696 - Avoid a vertical toolbar swipe opening tabs tray if currently searching r=#android-reviewers

The issue happened because the BrowserToolbarComposable's layout contains also the
Awesomebar so when searching the BrowserToolbarComposable's height is close to the
entire screen's height which would have ~any vertical swipe seen as swipes over the
toolbar that should open the tabs tray.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 2020810

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/fd83f8b9cadc
https://hg.mozilla.org/integration/autoland/rev/80204e5046f2
Avoid a vertical toolbar swipe opening tabs tray if currently searching r=android-reviewers,mcarare

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/80204e5046f2

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and 152 is affected.
:petru, is this bug important enough to require an uplift?

• If yes, please nominate the patch for Release approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox152 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Petru-Mugurel Lingurar [:petru]]

Adding back my NI to remember to ask for uplift after QA verifies the fix.

Comment 7

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: Recording_20260619_153134.mp4

This issue is verified as fixed on Firefox for Android Nightly 154 and Firefox 153 beta 1 build 2 on Samsung S24 Ultra (Android 16) and Google Pixel 10 pro (Android 16).

Comment 8

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: v152 introduced a new swipe up gesture on the bottom toolbar to open the tabstray that can conflict with the same gesture that puts the app to background and users complained about the conflict.
  These patches reduce the sensibility of our gesture to avoid the conflict.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: https://bugzilla.mozilla.org/show_bug.cgi?id=2046696#c0 & https://bugzilla.mozilla.org/show_bug.cgi?id=2037701#c0
• Risk associated with taking this patch: low
• Explanation of risk level: Small, targeted changes verified by QA.
• String changes made/needed?: --
• Is Android affected?: yes

Comment 9

[Petru-Mugurel Lingurar [:petru]]

Attachment: Bug 2046696 - Avoid a vertical toolbar swipe opening tabs tray if currently searching

The issue happened because the BrowserToolbarComposable's layout contains also the
Awesomebar so when searching the BrowserToolbarComposable's height is close to the
entire screen's height which would have ~any vertical swipe seen as swipes over the
toolbar that should open the tabs tray.

Original Revision: https://phabricator.services.mozilla.com/D306079

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/c18604d91b42
https://hg.mozilla.org/releases/mozilla-release/rev/626b2c3cd0a2

Comment 11

[Ryan VanderMeulen [:RyanVM]]

Added to the 152.0.4 relnotes.

Comment 12

[Mira Lobontiu (Android QA)]

Verified as fixed on the 152.0.4 Firefox for Android, using a Samsung Galaxy S24 (Android 16), and a Motorola Moto G30 (Android 12).