2046826 - Consider removing nsINntpUrl XPCOM interface

Status: RESOLVED FIXED

(MailNews Core :: General, task)

Description

[Hartmut Welpmann [:welpy-cw]]

The nsINntpUrl XPCOM interface and its C++ implementation (nsNntpUrl) are no longer needed. The NNTP protocol was modernized to use a JS-based NntpChannel (similar to Pop3Channel), which parses news URIs with new URL() instead of relying on the C++ URL parser. This makes the custom nsINntpUrl interface — which exposed parsed fields like newsAction, group, messageID, and key — entirely redundant.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: WIP: Bug 2046826 - Remove nsINntpUrl XPCOM interface. r=#thunderbird-back-end-reviewers

The nsINntpUrl interface and its nsNntpUrl implementation are no longer
needed. The NNTP protocol uses a JS-based NntpChannel which parses news
URIs with new URL() instead of relying on the C++ URL parser.

• Remove nsINntpUrl.idl, nsNntpUrl.h, and nsNntpUrl.cpp.
• Replace news URI creation with the generic nsMsgMailNewsUrl base class
  in NS_NewMailnewsURI.
• Replace QI<nsINntpUrl> type checks with scheme checks using a new
  IsNewsScheme() helper in nsMsgUtils.h.
• Move URL munging for authority-less news: URIs (RFC 5538) from
  nsNntpUrl into nsMsgMailNewsUrl.
• Move DEFAULT_NNTP_PORT / DEFAULT_NNTPS_PORT from nsINntpUrl to
  nsINntpIncomingServer.
• Remove dead nsIMsgMessageUrl property sets in
  NntpMessageService.sys.mjs.
• Remove @mozilla.org/messenger/nntpurl;1 from components.conf.
• Update tests and remove test_uriParser.js.

Comment 2

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 2046826 - Remove nsINntpUrl XPCOM interface. r=#thunderbird-back-end-reviewers

The nsINntpUrl interface and its nsNntpUrl implementation are no longer
needed. The NNTP protocol uses a JS-based NntpChannel which parses news
URIs with new URL() instead of relying on the C++ URL parser.

• Remove nsINntpUrl.idl, nsNntpUrl.h, and nsNntpUrl.cpp.
• Replace news URI creation with the generic nsMsgMailNewsUrl base class
  in NS_NewMailnewsURI.
• Replace QI<nsINntpUrl> type checks with scheme checks using a new
  IsNewsScheme() helper in nsMsgUtils.h.
• Move URL munging for authority-less news: URIs (RFC 5538) from
  nsNntpUrl into nsMsgMailNewsUrl.
• Move DEFAULT_NNTP_PORT / DEFAULT_NNTPS_PORT from nsINntpUrl to
  nsINntpIncomingServer.
• Remove dead nsIMsgMessageUrl property sets in
  NntpMessageService.sys.mjs.
• Remove @mozilla.org/messenger/nntpurl;1 from components.conf.
• Update tests and remove test_uriParser.js.
• Return null with NS_OK from GetServer() for news URIs without a
  configured account, matching the old nsNntpUrl behavior.
• Remove unused _tmpSubscribed from NntpIncomingServer.sys.mjs.
• Uncomment snews protocol handler test (protocol was registered long ago).

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/fc50bf666dab
Remove nsINntpUrl XPCOM interface. r=mkmelin