2046911 - [Wayland] Second D&D fails - only one wl_data_device is supported by compositors

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

Repeated D&D tab re-order fails.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 2025329

Comment 2

[lilydjwg]

Also dragging to bookmark or existing window fails for me, both Wayfire and KDE.

Comment 3

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

Looks like all compositors violate Wayland protocol somehow. KWin uses only first data_device and ignores any other and Mutter alternates active data device according to focus/device registration.

Comment 4

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

We may add a pref to fall back to Gtk D&D until it fixed or decided what to do.
Firefox Wayland D&D is needed for xdg-toplevel D&D implementation and perhaps also for better D&D handling.

Comment 5

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

Attachment: WIP: Bug 2046911 [Wayland] Use Gtk D&D backend and allow to switch to Wayland backend under a preference

Comment 7

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

I may also try to submit compositor patches for that.

Comment 9

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

Attachment: Bug 2046911 [Wayland] Rename nsDragSessionX11 to nsDragSessionGtk r?emilio

Comment 10

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

Attachment: Bug 2046911 [Wayland] Update nsDragSessionGtk to work on Wayland by default r?emilio

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f8f55a34484f
https://hg.mozilla.org/integration/autoland/rev/1026d63b59f5
[Wayland] Rename nsDragSessionX11 to nsDragSessionGtk r=emilio
https://github.com/mozilla-firefox/firefox/commit/c9db19c46539
https://hg.mozilla.org/integration/autoland/rev/e0a3419dd215
[Wayland] Update nsDragSessionGtk to work on Wayland by default r=emilio

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/83364c5d05db
https://hg.mozilla.org/integration/autoland/rev/6e3fac7b7b94
Revert "Bug 2046911 [Wayland] Update nsDragSessionGtk to work on Wayland by default r=emilio" for causing build bustages in nsWindow.cpp

Comment 14

[Cristian Tuns]

Backed out for causing build bustages

• Backout link
• Push with failures
• Failure Log
• Failure line: /builds/worker/checkouts/gecko/widget/gtk/nsWindow.cpp:X:21: error: no member named 'widget_wayland_native_data_session_AtStartup' in namespace 'mozilla::StaticPrefs'

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e1e5c19d4d75
https://hg.mozilla.org/integration/autoland/rev/0ca7397a4e82
[Wayland] Rename nsDragSessionX11 to nsDragSessionGtk r=emilio
https://github.com/mozilla-firefox/firefox/commit/d54a3493937b
https://hg.mozilla.org/integration/autoland/rev/ba393edc4139
[Wayland] Update nsDragSessionGtk to work on Wayland by default r=emilio
https://github.com/mozilla-firefox/firefox/commit/b154408de5ea
https://hg.mozilla.org/integration/autoland/rev/4833fd1d9ba0
apply code formatting via Lando

Comment 16

[Silaghi Andreea]

Backed out for causing bp-nu bustages
Backout Link
Push with failures
Failure Log
Failure line /builds/worker/checkouts/gecko/widget/gtk/nsDragServiceGtk.cpp:X:9: error: no member named 'GdkIsWaylandDisplay' in namespace 'mozilla::widget'; did you mean 'GdkWaylandDisplay'?

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a6cadb1388f0
https://hg.mozilla.org/integration/autoland/rev/7dd16ac0d9a8
[Wayland] Rename nsDragSessionX11 to nsDragSessionGtk r=emilio
https://github.com/mozilla-firefox/firefox/commit/e6f8dbb7e36f
https://hg.mozilla.org/integration/autoland/rev/9063cc9b9b36
[Wayland] Update nsDragSessionGtk to work on Wayland by default r=emilio
https://github.com/mozilla-firefox/firefox/commit/ad0bf197e662
https://hg.mozilla.org/integration/autoland/rev/6c9f05742a83
apply code formatting via Lando

Comment 18

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/7dd16ac0d9a8
https://hg.mozilla.org/mozilla-central/rev/9063cc9b9b36
https://hg.mozilla.org/mozilla-central/rev/6c9f05742a83

Comment 19

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

Attachment: Bug 2046911 [Wayland] Rename nsDragSessionX11 to nsDragSessionGtk

Original Revision: https://phabricator.services.mozilla.com/D306695

Comment 20

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Broken D&D on Linux/Wayland.
• Code covered by automated testing?: no
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Can't be worse.
• String changes made/needed?: none
• Is Android affected?: no

Comment 21

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

Attachment: Bug 2046911 [Wayland] Update nsDragSessionGtk to work on Wayland by default

Original Revision: https://phabricator.services.mozilla.com/D306696

Comment 22

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

Kwin bug: https://bugs.kde.org/show_bug.cgi?id=521494
Mutter bug: https://gitlab.gnome.org/GNOME/mutter/-/work_items/4863
WLRoots bug: https://gitlab.freedesktop.org/wlroots/wlroots/-/work_items/4105

Comment 23

[Martin Stránský [:stransky] (ni? me) (PTO till June 6)]

File follow up as Bug 2047823.

Comment 24

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/06f3f6a70ee0
https://hg.mozilla.org/releases/mozilla-beta/rev/ddffa4552027
https://github.com/mozilla-firefox/firefox/commit/f3dec900207f
https://hg.mozilla.org/releases/mozilla-beta/rev/4041922b2ad7