2046918 - Move FastTransform to webrender_api crate

Status: ASSIGNED

(Core :: Graphics: WebRender, task)

Description

[Nico Burns]

Servo has made this type public and it using it outside of WebRender (along with other webrender_api types). However, that it causing crates to depend on webrender rather than just webrender_api which pessimises our build parallelism. This moves the type from webrender into webrender_api solving that issue.

(patch incoming)

Comment 1

[Nico Burns]

Attachment: Bug 2046918: Move FastTransform to webrender_api crate r=#gfx-reviewers

Signed-off-by: Nico Burns <[e-mail]>

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ec130a8e644d
https://hg.mozilla.org/integration/autoland/rev/cee816652bad
Move FastTransform to webrender_api crate r=gfx-reviewers,nical

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d1c4905f3157
https://hg.mozilla.org/integration/autoland/rev/5e7f922b81cf
Revert "Bug 2046918: Move FastTransform to webrender_api crate r=gfx-reviewers,nical" for causing webrender bustages.

Comment 4

[agoloman]

Backed out for causing webrender bustages.

• Backout link
• Push with failures
• Failure Log

Comment 5

[Nico Burns]

I've tried to manually fix the format errors. But I am unable to reproduce the lint locally (./mach format and ./mach lint both return no errors), and ./mach try isn't letting me login (internal Mozilla login now seems to be the only option).

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

There is an r+ patch which didn't land and no activity in this bug for 1 week.
:nico, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.