204731 - Variant properties, if empty cause a crash

Status: VERIFIED FIXED

(Core :: XPConnect, defect)

Description

[David Bradley]

When retrieving a variant property, if the variant is empty, it causes a crash.
This is due to the fact that the code was testing the return value for "empty"
to decided if it actually returned a value. Solution is to initialize the JS's
return value parameter to JSVAL_VOID.

Patch coming up.

Comment 1

[David Bradley]

Attachment: Simple one line initialization of *retval

Comment 2

[David Bradley]

Comment on attachment 122664 [details] [diff] [review]
Simple one line initialization of *retval

Looking for reviews for this simple one liner

Comment 3

[Adam Lock]

Comment on attachment 122664 [details] [diff] [review]
Simple one line initialization of *retval

r=adamlock

Comment 4

[Alec Flett]

Comment on attachment 122664 [details] [diff] [review]
Simple one line initialization of *retval

sr=alecf

Comment 5

[David Bradley]

Comment on attachment 122664 [details] [diff] [review]
Simple one line initialization of *retval

I'd like to get this in to 1.4, it's a one liner with little risk, and prevents
a potential crash in the in the IDispatch code when properties hold an empty
variant.

Comment 6

[Asa Dotzler [:asa]]

Comment on attachment 122664 [details] [diff] [review]
Simple one line initialization of *retval

a=asa (on behalf of drivers) for checkin to 1.4.

Comment 7

[David Bradley]

Patch checked in

Comment 8

[Phil Schwartau]

Checkin Verified -