2047352 - Stacktrace is not available for in-memory cached scripts

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect)

Description

[Tooru Fujisawa [:arai]]

When the Stencil navigation cache is enabled (bug 1670403), the netmonitor doesn't show the stacktrace for the script request.

So far the following seems to be the place where the stacktrace is set.
That sounds like it should hook into http-on-resource-cache-response or maybe a new notification for the cached response,
and extract the stack trace there.

https://searchfox.org/firefox-main/rev/1d85bc4044b2efc1f6b59e8dff45e0de9bbe353d/devtools/server/actors/resources/network-events-stacktraces.js#133-135,157,188

switch (topic) {
  case "http-on-opening-request":
  case "document-on-opening-request": {
...
  case "network-monitor-alternate-stack": {
...
this._setStackTrace(id, stacktrace);

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 2047352 - Reflect the stack trace for the in-memory cached script in the Network Monitor. r?#devtools-reviewers!,nbp!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d572646d59ff
https://hg.mozilla.org/integration/autoland/rev/f3b397d8af2f
Reflect the stack trace for the in-memory cached script in the Network Monitor. r=devtools-reviewers,bomsy,bthrall

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/f3b397d8af2f

Comment 4

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: If the Stencil navigation cache pref is enabled:

1. Discord stops working
2. DevTools Network monitor doesn't show the stack trace for cached script requests

The pref is disabled by default on non-nightly right now, but we're planning to perform an experiment there.
(same situation as bug 2042605)

• Code covered by automated testing?: no
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: none
• Risk associated with taking this patch: low
• Explanation of risk level: This delays the script processing, which is in between the "pref is disabled" situation and the "unpatched, pref is enabled" situation.
• String changes made/needed?: none
• Is Android affected?: yes

Comment 5

[Tooru Fujisawa [:arai]]

Attachment: Bug 2047352 - Reflect the stack trace for the in-memory cached script in the Network Monitor.

Original Revision: https://phabricator.services.mozilla.com/D306595

Comment 6

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/2a10ce1f80ed
https://hg.mozilla.org/releases/mozilla-beta/rev/c163aa1cc8ca

Comment 7

[Mathew Hodson]

Oops, I didn't mean to put the bug in the Regressed By field. I meant Depends since its building on top of code added in bug 2043993

Comment 8

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2027803