2047355 - Time picker button is visible on disabled fields

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect, P3)

Description

[Sam Johnson]

When dom.forms.datetime.timepicker is enabled, <input type="time" disabled> shows a picker button, even though picker buttons should not be visible on disabled fields.

Comment 1

[Sam Johnson]

Attachment: Bug 2047355 - Fix time picker button visible on disabled fields. r?#recomp-reviewers

Adjusts the order of CSS rules so that the time picker button is correctly hidden when the input is disabled.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c4492fc48c3d
https://hg.mozilla.org/integration/autoland/rev/fafa88e9722e
Fix time picker button visible on disabled fields. r=mkennedy

Comment 3

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/fafa88e9722e

Comment 4

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:sam, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox153 to wontfix.

For more information, please visit BugBot documentation.

Comment 5

[Sam Johnson]

No need to uplift as this is disabled by default.