2047486 - Address bar doesn't decode unicode characters in the URL

Status: RESOLVED FIXED

(Firefox for Android :: Toolbar, defect)

Description

[YeongChan Lee]

Steps to reproduce:

1. Navigate to a URL containing unicode characters. For example: https://ko.wikipedia.org/wiki/위키백과:대문
2. Observe how the URL is represented in the address bar.

Actual results:

The unicode part is %-encoded, making it hard for users to read or edit it. (https://ko.wikipedia.org/wiki/%EC%9C%84%ED%82%A4%EB%B0%B1%EA%B3%BC:%EB%8C%80%EB%AC%B8)

Expected results:

The unicode part stays decoded as unicode characters. This is also consistent with the PC version. (https://ko.wikipedia.org/wiki/위키백과:대문)

Version info:

OS: Android 10 (API 29)
Firefox: Nightly build 20260611082734

Comment 1

[neoyarus]

Attachment: Bug 2047486 - Use desktop formatting rules for URLs shown on Android. r?#android-reviewers

The address bar displays readable Unicode and spaces in HTTP/S URLs using a Kotlin port of Firefox desktop's losslessDecodeDisplaySpec.

The formatter follows desktop's character and whitespace rules, using Android's Unicode categories. It leaves the authority unchanged and does not reformat text while typing. Dedicated copy and share actions use the original URL. Tests compare the formatter with 45 cases generated by the desktop helper.

Comment 2

[neoyarus]

Attachment: Bug 2047486 - Add lossless URL formatters to URLStringUtils. r?#android-reviewers

toLosslessDisplayUrl and toLosslessEditableUrl port desktop's losslessDecodeDisplaySpec, so every Android surface that shows a URL can decode it the same way desktop does. The shared toDisplayUrl and toShortUrl helpers use them. Tests compare the formatter with 45 cases generated by the desktop helper.

Comment 3

[neoyarus]

Attachment: Bug 2047486 - Add address-bar privacy instrumentation tests. r?#android-reviewers

The remote search suggestion test only runs the permission combinations that behave differently, and the other tests run on the four focus and browsing-mode combinations, which keeps the CI cost down.

Comment 4

[neoyarus]

Attachment: Bug 2047486 - Show suggestion titles made from their URL in a readable form. r?#android-reviewers

Places titles a URL match with its stored URL minus the scheme, so typing an encoded path showed an encoded title above the readable URL.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d1ea733b2e3d
https://hg.mozilla.org/integration/autoland/rev/26fa3a03dd43
Add lossless URL formatters to URLStringUtils. r=android-reviewers,petru
https://github.com/mozilla-firefox/firefox/commit/b37b4fc34df2
https://hg.mozilla.org/integration/autoland/rev/033704890340
Use desktop formatting rules for URLs shown on Android. r=android-reviewers,petru
https://github.com/mozilla-firefox/firefox/commit/95d7d0ae5f41
https://hg.mozilla.org/integration/autoland/rev/b8dfa33ea729
Add address-bar privacy instrumentation tests. r=android-reviewers,petru
https://github.com/mozilla-firefox/firefox/commit/1ca97bfffffb
https://hg.mozilla.org/integration/autoland/rev/f3c1dd0aa325
Show suggestion titles made from their URL in a readable form. r=android-reviewers,petru

Comment 6

[rperta]

https://hg.mozilla.org/mozilla-central/rev/26fa3a03dd43
https://hg.mozilla.org/mozilla-central/rev/033704890340
https://hg.mozilla.org/mozilla-central/rev/b8dfa33ea729
https://hg.mozilla.org/mozilla-central/rev/f3c1dd0aa325

Comment 7

[Donal Meehan [:dmeehan]]

Did you want to nominate this for the Fx160 relnotes? If so, set the relnote-firefox flag to "?"
https://wiki.mozilla.org/Release_Management/Release_Notes_Nomination

Possible wording:

Web addresses containing non-Latin characters are now shown in readable form in the address bar and elsewhere in the app, instead of as encoded text.

Comment 8

[neoyarus]

Release Note Request (optional, but appreciated)
[Why is this notable]: Makes web addresses containing non-Latin characters readable in the address bar and elsewhere in Firefox for Android, consistent with Firefox desktop.
[Affects Firefox for Android]: Yes
[Suggested wording]: Web addresses containing non-Latin characters are now shown in readable form in the address bar and elsewhere in the app, instead of as encoded text.
[Links (documentation, blog post, etc)]: None

Comment 9

[Donal Meehan [:dmeehan]]

Thanks, added to the Fx160 nightly release notes, please allow 30 minutes for the site to update. This will carry over to the Fx160 beta release notes and eventually the Fx160 release notes.