2047491 - CTRL+up/down arrow does not re-order the search engines correctly anymore

Status: VERIFIED FIXED

(Firefox :: Search, defect, P3)

Description

[Cristian Baica [:cbaica], Release Desktop QA]

Attachment: ctrl shift up or down arrow does not move engine correctly

Affected versions

• Fx 153.0a1
• Fx 152.0

Affected platforms

• Windows
• macOS
• Ubuntu

Steps to reproduce

1. Launch Firefox and navigate to about:preferences#search.
2. Use tab to cycle through options until the search table is reached and one engine is highlighted.
3. Hold CTRL+SHIFT and press down/up arrow to re-order engines.

Expected result

• Search engine is correctly moved up or down, per user input.

Actual result

• Engines are incorrectly moved.

Regression range

• First bad: 2026-06-02
• Last good: 2026-06-01
• Pushlog: https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=6f0be35ec648a93392f27bea08e86ab00f775474&tochange=1a758d4c328e8311453e6f3cebbda124f29bdf3b
• Potentially regressed by: 2038148.

Additional notes

• For macOS, to reproduce the issue, hold down CTRL, not command key.

Comment 1

[Marco Bonardo [:mak]]

Worth investigating if the issue is in the search panel, or the reusable component.

Stephanie, any ideas?

Comment 2

[Stephanie Cunnane [:scunnane]]

Thanks for finding this, Cristian. Yes, it is at the level of the reusable component (a moz-box-group). Bug 2038148 fixed a moz-box-group item reordering bug. It handled item reordering via the mouse but missed the keyboard reordering case. I can post a patch and uplift it when it's ready to go.

Comment 3

[BugBot [:suhaib / :marco]]

:mstriemer, since you are the author of the regressor, bug 2038148, could you take a look?

For more information, please visit BugBot documentation.

Comment 4

[Stephanie Cunnane [:scunnane]]

Mark, probably no need for you to also investigate. I'm in the middle of getting a recomp patch up and will add you as the reviewer.

Comment 5

[Stephanie Cunnane [:scunnane]]

Attachment: Bug 2047491 - Ensure CTRL+SHIFT+up/down reorders items correctly in moz-reorderable-lists. r?mstriemer!

Comment 6

[Dianna Smith [:diannaS]]

:scunnane in triage mtg and wondering if this patch is ready for review? Wondering if we should NI mark in order to get this into a 152 dot release. if not, please mark 152 as wontfix

Comment 7

[Stephanie Cunnane [:scunnane]]

Hi Dianna, I got this reviewed today. Doing a try push now, then I'll land and uplift to Beta and a 152 dot release.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d20cfc79c7c4
https://hg.mozilla.org/integration/autoland/rev/ee545f606423
Ensure CTRL+SHIFT+up/down reorders items correctly in moz-reorderable-lists. r=mstriemer

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/ee545f606423

Comment 10

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:scunnane, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox153 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Stephanie Cunnane [:scunnane]]

Attachment: Bug 2047491 - Ensure CTRL+SHIFT+up/down reorders items correctly in moz-reorderable-lists.

Bug 2038148 fixed a moz-box-group item reordering bug. It handled item reordering via the mouse but missed the keyboard reordering case. This patch covers the keyboard reordering case.

Note that in several places I've switched to working with engine ids vs. engine names. In the search service code, we are making a concerted effort to prefer engine ids to engine names, as engine ids are the more robust property to work with.

Original Revision: https://phabricator.services.mozilla.com/D306819

Comment 12

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Users trying to reorder their search engine list (about:preferences#search) via the keyboard cannot reorder them as expected.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: low
• Explanation of risk level: This has been manually tested, has automated tests and has already landed in Nightly.
• String changes made/needed?: No
• Is Android affected?: no

Comment 13

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Users trying to reorder their search engine list (about:preferences#search) via the keyboard cannot reorder them as expected.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: low
• Explanation of risk level: This has been manually tested, has automated tests and has already landed in Nightly
• String changes made/needed?: n/a
• Is Android affected?: no

Comment 14

[Stephanie Cunnane [:scunnane]]

Attachment: Bug 2047491 - Ensure CTRL+SHIFT+up/down reorders items correctly in moz-reorderable-lists.

Bug 2038148 fixed a moz-box-group item reordering bug. It handled item reordering via the mouse but missed the keyboard reordering case. This patch covers the keyboard reordering case.

Note that in several places I've switched to working with engine ids vs. engine names. In the search service code, we are making a concerted effort to prefer engine ids to engine names, as engine ids are the more robust property to work with.

Original Revision: https://phabricator.services.mozilla.com/D306819

Comment 15

[Stephanie Cunnane [:scunnane]]

Attachment: Bug 2047491 - Ensure CTRL+SHIFT+up/down reorders items correctly in moz-reorderable-lists.

Bug 2038148 fixed a moz-box-group item reordering bug. It handled item reordering via the mouse but missed the keyboard reordering case. This patch covers the keyboard reordering case.

Note that in several places I've switched to working with engine ids vs. engine names. In the search service code, we are making a concerted effort to prefer engine ids to engine names, as engine ids are the more robust property to work with.

Original Revision: https://phabricator.services.mozilla.com/D306819

Comment 16

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: Users trying to reorder their search engine list (about:preferences#search) via the keyboard cannot reorder them as expected.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: n/a
• Risk associated with taking this patch: low
• Explanation of risk level: This has been manually tested, has automated tests and has already landed in Nightly
• String changes made/needed?: n/a
• Is Android affected?: no

Comment 17

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/99a59ab81610
https://hg.mozilla.org/releases/mozilla-beta/rev/80188d29af1d

Comment 18

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2026-06-14 Firefox Nightly build on Windows 10.

Verified as fixed on Firefox Nightly 154.0a1 and Firefox 153.0b4 on Windows 10, Ubuntu 22, macOS 13.

Leaving the qe-verify+ flag momentarily until the fix is uplifted to the release build as well.

Comment 19

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/391df242bdc3
https://hg.mozilla.org/releases/mozilla-release/rev/def6afc7ff6f

Comment 20

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Verified as fixed on Firefox 152.0.4 on Windows 10, Ubuntu 22, macOS 13.