2047506 - script.callFunction fails when moz:debugging is paused

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, defect)

Description

[Julian Descottes [:jdescottes]]

The current implementation for callFunction mixes objects originating from two distinct Debugger compartments: https://searchfox.org/firefox-main/rev/4524afcc186654ad357e48fec686249515860ac8/remote/shared/Realm.sys.mjs#341-351

const bindings = {
  __bidi_args: this.#createDebuggerObject(args),
  __bidi_this: this.#createDebuggerObject(thisParameter),
};

if (pausedDebuggerFrame) {
  return pausedDebuggerFrame.evalWithBindings(expression, bindings, {
    bypassCSP: true,
    url: this.#window.document.baseURI,
  });
}

pausedDebuggerFrame is using the debugger instance from the moz:debugging module, while #createDebuggerObject will use the debugger of the realm itself. We need different debuggers, however in this case we should create the "args" and "this" by reusing the same Debugger instance as the paused frame, meaning we probably need to expose the Debugger in addition to the pausedDebuggerFrame.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 2047506 - [bidi] Fix script.callFunction to use correct Debugger context when paused

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1b1b47af7339
https://hg.mozilla.org/integration/autoland/rev/f74f2bce8fe0
[bidi] Fix script.callFunction to use correct Debugger context when paused r=Sasha

Comment 3

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/f74f2bce8fe0