Closed Bug 2047558 Opened 22 days ago Closed 12 hours ago

The History grid view is truncated when overlapping the Smart bar

Categories

(Core :: Machine Learning: Frontend, defect)

Desktop
Unspecified
defect

Tracking

()

RESOLVED FIXED
154 Branch
Tracking Status
firefox153 --- affected
firefox154 --- verified

People

(Reporter: rdoghi, Assigned: omarg)

References

(Blocks 1 open bug)

Details

(Whiteboard: [aife])

Attachments

(8 files)

Attached video ThumbnailGrid.mp4

Found in

  • Nightly 153.0a1 (2026-06-15)

Affected versions

  • Nightly 153.0a1 (2026-06-15)

Affected platforms

  • all

Steps to reproduce

  1. Enable Smart Window.
  2. Have some history saved.
  3. Ask the assistant to show you the pages recently visited.
  4. Scroll down untill the Thumbnails overlap the Smart bar.

Expected result

  • The Thumbnail Grid items should show a Blur effect when reaching the Smart bar or a fade out animation as they scroll beneath the Smart bar.

Actual result

  • The Thumbnail Grid items are overlaping the Smart Bar and its animation.

Regression range
N/A

The severity field is not set for this bug.
:Mardak, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(edilee)

From what I can tell the history grid is rendering behind the Smartbar, and the Smartbar glow animation also is above the grid.

When the grid scrolls out of view, it is behind the smartbar, this looks consistent with the way text renders when it scrolls out of frame.

And I also see the same in the Figma designs here: https://www.figma.com/design/75Z1LtkCEUJWCxoY2KyNHv/Smart-Window-Q2?node-id=3577-146714&m=dev

Is there some other design or document you're referencing a fade out animation or a blur effect?

Flags: needinfo?(rdoghi)
Severity: -- → S4
Flags: needinfo?(edilee)
Attached image truncated.png

Those are the files but in Firefox it looks a bit different, also if you look at the smart bar where the grid falls behind it it looks as if there is a corner there instead of the round border.

Flags: needinfo?(rdoghi)

Sorry, but what is the expectation here :rdoghi? The history grid implementation did not change anything about how the scrolling area works, and I'm not understanding what you're pointing out as a problem since to me it looks like it's always looked, and it also looks to be matching the Figma, unless there is some specific thing about the Figma you're seeing as different in the scroll area. Can you point to a screenshot in the Figma of what it is you see as a problem here so that I can see what I'm missing, thank you!

Flags: needinfo?(rdoghi)
Attached image grid.png

Ok so here is a screenshort from our latest Nightly build, I tried to draw some lines to highlight the issue.. First it seems that the grid spills on the right side of the Smart bar, which was the initial issue (vertical Red line from the Smart bar), and also that it stops at the top of the smart bar which makes it look as if it stops mid air instead of flowing behind the smart bar, my suggestions would be to have the text and grid and everything else from chat to have the exact size as the smart bar just like with the left border and also have the text and grid go lower behind the smart bar all the way down to the highlighted Black line (the text would still be blurred in that area and far less visible once the animation is displayed at the top) but it would look as if the text and History grid is hiding behind the Smart bar.

But this is just an idea, the main issue here which is a small one is that the grid thumbnails are wider than the smart bar area by 5px, we can also close this as a wont fix or change it to an enhancement for future implementations, I realize theres a lot more important issues to take care of.

Flags: needinfo?(rdoghi)
Attached image figma7.png

This is the only screenshot I could get from Figma that shows the Grid all the way down to the Smart bar, and this made me believe that the Grid thumbnails should not reach the edges of the smart bar.

I see now, I think the problem here is the Smartbar doesn't fill the content area, as the history thumbnails are filling the available content area DOM element. I think this was probably harder to see in the past when it was just text, but now that there are DOM elements that are filling the available space this is more visible.

As far as the scrollable height, we can maybe pull this off a bit by adding some negative margin on the content container and having some padding on the inside so lines of text don't end up staying below the top of the smartbar, effectively partially hidden.

Thanks for the clarification I'll take a look at this.

(In reply to Rares Doghi, Desktop QA from comment #9)

Created attachment 9602690 [details]
figma7.png

This is the only screenshot I could get from Figma that shows the Grid all the way down to the Smart bar, and this made me believe that the Grid thumbnails should not reach the edges of the smart bar.

Yes there are a couple of issues with the smartbar/content area in regards to design. The content area is also not the right width, which is why when I pointed it out to design we ended up changing the history grid to be two across instead of three across, because right now on production the content area is a bit smaller than it is in the designs.

Assignee: nobody → ogonzalez
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 12 hours ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch

Verified as fixed in our latest Nightly 154.0a1 (2026-07-07).

QA Whiteboard: [qa-found-in-c153][QA-4747][S4] → [qa-found-in-c153][QA-4747][S4][qa-ver-needed-c154/b153]
QA Contact: rdoghi
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: