The History grid view is truncated when overlapping the Smart bar
Categories
(Core :: Machine Learning: Frontend, defect)
Tracking
()
People
(Reporter: rdoghi, Assigned: omarg)
References
(Blocks 1 open bug)
Details
(Whiteboard: [aife])
Attachments
(10 files)
|
4.14 MB,
video/mp4
|
Details | |
|
713.00 KB,
image/png
|
Details | |
|
1.62 MB,
image/png
|
Details | |
|
1.11 MB,
image/png
|
Details | |
|
20.35 KB,
image/png
|
Details | |
|
163.31 KB,
image/png
|
Details | |
|
397.76 KB,
image/png
|
Details | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-beta+
|
Details | Review |
|
274.96 KB,
image/png
|
Details |
Found in
- Nightly 153.0a1 (2026-06-15)
Affected versions
- Nightly 153.0a1 (2026-06-15)
Affected platforms
- all
Steps to reproduce
- Enable Smart Window.
- Have some history saved.
- Ask the assistant to show you the pages recently visited.
- Scroll down untill the Thumbnails overlap the Smart bar.
Expected result
- The Thumbnail Grid items should show a Blur effect when reaching the Smart bar or a fade out animation as they scroll beneath the Smart bar.
Actual result
- The Thumbnail Grid items are overlaping the Smart Bar and its animation.
Regression range
N/A
Updated•2 months ago
|
Comment 1•2 months ago
|
||
The severity field is not set for this bug.
:Mardak, could you have a look please?
For more information, please visit BugBot documentation.
From what I can tell the history grid is rendering behind the Smartbar, and the Smartbar glow animation also is above the grid.
When the grid scrolls out of view, it is behind the smartbar, this looks consistent with the way text renders when it scrolls out of frame.
And I also see the same in the Figma designs here: https://www.figma.com/design/75Z1LtkCEUJWCxoY2KyNHv/Smart-Window-Q2?node-id=3577-146714&m=dev
Is there some other design or document you're referencing a fade out animation or a blur effect?
| Reporter | ||
Comment 6•2 months ago
|
||
Those are the files but in Firefox it looks a bit different, also if you look at the smart bar where the grid falls behind it it looks as if there is a corner there instead of the round border.
Sorry, but what is the expectation here :rdoghi? The history grid implementation did not change anything about how the scrolling area works, and I'm not understanding what you're pointing out as a problem since to me it looks like it's always looked, and it also looks to be matching the Figma, unless there is some specific thing about the Figma you're seeing as different in the scroll area. Can you point to a screenshot in the Figma of what it is you see as a problem here so that I can see what I'm missing, thank you!
| Reporter | ||
Comment 8•2 months ago
|
||
Ok so here is a screenshort from our latest Nightly build, I tried to draw some lines to highlight the issue.. First it seems that the grid spills on the right side of the Smart bar, which was the initial issue (vertical Red line from the Smart bar), and also that it stops at the top of the smart bar which makes it look as if it stops mid air instead of flowing behind the smart bar, my suggestions would be to have the text and grid and everything else from chat to have the exact size as the smart bar just like with the left border and also have the text and grid go lower behind the smart bar all the way down to the highlighted Black line (the text would still be blurred in that area and far less visible once the animation is displayed at the top) but it would look as if the text and History grid is hiding behind the Smart bar.
But this is just an idea, the main issue here which is a small one is that the grid thumbnails are wider than the smart bar area by 5px, we can also close this as a wont fix or change it to an enhancement for future implementations, I realize theres a lot more important issues to take care of.
| Reporter | ||
Comment 9•2 months ago
|
||
This is the only screenshot I could get from Figma that shows the Grid all the way down to the Smart bar, and this made me believe that the Grid thumbnails should not reach the edges of the smart bar.
| Assignee | ||
Comment 10•2 months ago
|
||
I see now, I think the problem here is the Smartbar doesn't fill the content area, as the history thumbnails are filling the available content area DOM element. I think this was probably harder to see in the past when it was just text, but now that there are DOM elements that are filling the available space this is more visible.
As far as the scrollable height, we can maybe pull this off a bit by adding some negative margin on the content container and having some padding on the inside so lines of text don't end up staying below the top of the smartbar, effectively partially hidden.
Thanks for the clarification I'll take a look at this.
| Assignee | ||
Comment 11•2 months ago
|
||
(In reply to Rares Doghi, Desktop QA from comment #9)
Created attachment 9602690 [details]
figma7.pngThis is the only screenshot I could get from Figma that shows the Grid all the way down to the Smart bar, and this made me believe that the Grid thumbnails should not reach the edges of the smart bar.
Yes there are a couple of issues with the smartbar/content area in regards to design. The content area is also not the right width, which is why when I pointed it out to design we ended up changing the history grid to be two across instead of three across, because right now on production the content area is a bit smaller than it is in the designs.
| Assignee | ||
Comment 12•2 months ago
|
||
Updated•2 months ago
|
Comment 13•1 month ago
|
||
Comment 14•1 month ago
|
||
| bugherder | ||
| Reporter | ||
Comment 15•1 month ago
|
||
Verified as fixed in our latest Nightly 154.0a1 (2026-07-07).
Comment 16•1 month ago
|
||
The patch landed in nightly and beta is affected.
:omarg, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
- If no, please set
status-firefox153towontfix.
For more information, please visit BugBot documentation.
| Assignee | ||
Comment 17•1 month ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D309742
Updated•1 month ago
|
Comment 18•1 month ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined/Reason for urgency: Smart Window UI fix to render content correctly aligned.
- Code covered by automated testing?: no
- Fix verified in Nightly?: yes
- Needs manual QE testing?: yes
- Steps to reproduce for manual QE testing: - Open Smart Window
- Start conversation, long enough to scroll
- Content should center to Smartbar Input
- Risk associated with taking this patch: low
- Explanation of risk level: Minor CSS changes to fix content/smartbar input alignment with each other.
- String changes made/needed?: None
- Is Android affected?: no
Updated•1 month ago
|
Updated•1 month ago
|
Comment 20•1 month ago
|
||
| uplift | ||
| Reporter | ||
Comment 21•1 month ago
|
||
This issue still occurs in our latest Beta 153.0b11 from treeherder, was this backed out from Beta ? @Omar
| Assignee | ||
Comment 22•1 month ago
|
||
:rdoghi It does not looked backed out to me, I still see the two CSS line updates:
https://github.com/mozilla-firefox/firefox/blob/beta/browser/components/aiwindow/ui/components/ai-window/ai-window.css#L102
https://github.com/mozilla-firefox/firefox/blob/beta/browser/components/aiwindow/ui/components/ai-chat-content/ai-chat-content.css#L29
| Reporter | ||
Comment 23•1 month ago
|
||
:omarg here is how it looks in Nightly and our latest Beta 153.0b13, is it because of the smart bar thats missing the latest style ? it does not look fixed in beta.
| Assignee | ||
Comment 24•1 month ago
|
||
:rdoghi I'm not sure what the cause is, I'll take a look at the beta branch today to try to identify what's missing here
Description
•