2047784 - Investigate removing `--urlbar-height`

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Drew Willcoxon :adw]

We discussed removing --urlbar-height in at least three Phab revisions:

• https://phabricator.services.mozilla.com/D301257
• https://phabricator.services.mozilla.com/D306354#10635858
• https://phabricator.services.mozilla.com/D297579 (to a lesser extent)

We should see whether that's possible, which would simplify things a little.

Note there's also a --urlbar-min-height that (probably?) can't be removed.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 2047784 - Avoid computing --urlbar-height in JS

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 2047784 - Avoid computing --urlbar-container-height in JS

Comment 3

[Drew Willcoxon :adw]

Setting qe-verify+ because it would be nice to do a little regression testing to make sure the urlbar's height and position remain correct in a variety of scenarios:

• Nova enabled
• Nova disabled
• Compact and touch UI densities
• Different themes
• Different platforms

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a76763682812
https://hg.mozilla.org/integration/autoland/rev/526cd0920cc1
Avoid computing --urlbar-height in JS r=desktop-theme-reviewers,adw,dao

Comment 5

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/526cd0920cc1

Comment 6

[Petruta Horea [:phorea]]

(In reply to Drew Willcoxon :adw from comment #3)

Setting qe-verify+ because it would be nice to do a little regression testing to make sure the urlbar's height and position remain correct in a variety of scenarios:

• Nova enabled
• Nova disabled
• Compact and touch UI densities
• Different themes
• Different platforms

Verified as fixed the above scenarios on Firefox 155 beta 4 and Nightly 156.0a1 across platforms.