2047849 - Onboarding clean up and refactor

Status: RESOLVED FIXED

(Firefox for Android :: Onboarding, enhancement)

Description

[twhite (OOO 3rd July - 10th July)]

Summary

This bug tracks a set of clean-up and refactoring tasks in the onboarding code:

• Remove the shouldShowElevation parameter and use the existing isSmall flag for gating logic instead.
• Rename the func parameter in toPageUiData to jexlEvaluator for improved clarity.
• Reorder toPageUiData parameters to group JEXL-related parameters together.
• Hoist the manufacturer check out of toPageUiData, reducing complexity and allowing removal of the LongParameterList suppression.
• Reorder private functions in OnboardingMapper to follow call order and improve readability.

Comment 1

[twhite (OOO 3rd July - 10th July)]

Attachment: WIP: Bug 2047849 - Part 1: Remove the shouldShowElevation parameter and use the existing isSmall flag for gating logic instead.

Comment 2

[twhite (OOO 3rd July - 10th July)]

Attachment: Bug 2047849 - Part 1: Remove the shouldShowElevation parameter and use the existing isSmall flag for gating logic instead.

Comment 3

[twhite (OOO 3rd July - 10th July)]

Attachment: Bug 2047849 - Part 2: Rename the func parameter in toPageUiData to jexlEvaluator for improved clarity.

Comment 4

[twhite (OOO 3rd July - 10th July)]

Attachment: Bug 2047849 - Part 3: Reorder toPageUiData parameters to group JEXL-related parameters together.

Comment 5

[twhite (OOO 3rd July - 10th July)]

Attachment: Bug 2047849 - Part 4: Hoist the manufacturer check out of toPageUiData, reducing complexity and allowing removal of the LongParameterList suppression.

Comment 6

[twhite (OOO 3rd July - 10th July)]

Attachment: Bug 2047849 - Part 5: Reorder private functions in OnboardingMapper to follow call order and improve readability.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ec7a129cc8fd
https://hg.mozilla.org/integration/autoland/rev/640f9fea8c59
Part 1: Remove the shouldShowElevation parameter and use the existing isSmall flag for gating logic instead. r=android-reviewers,marcin
https://github.com/mozilla-firefox/firefox/commit/653f0105daf6
https://hg.mozilla.org/integration/autoland/rev/1fd1bb50cbc8
Part 2: Rename the func parameter in toPageUiData to jexlEvaluator for improved clarity. r=android-reviewers,alastun,marcin
https://github.com/mozilla-firefox/firefox/commit/e154219a0916
https://hg.mozilla.org/integration/autoland/rev/2df45d84bb96
Part 3: Reorder toPageUiData parameters to group JEXL-related parameters together. r=android-reviewers,marcin,alastun
https://github.com/mozilla-firefox/firefox/commit/1abfd09391b1
https://hg.mozilla.org/integration/autoland/rev/d00648aa23f5
Part 4: Hoist the manufacturer check out of toPageUiData, reducing complexity and allowing removal of the LongParameterList suppression. r=android-reviewers,marcin,alastun
https://github.com/mozilla-firefox/firefox/commit/be5381b80af5
https://hg.mozilla.org/integration/autoland/rev/6b6907f350cb
Part 5: Reorder private functions in OnboardingMapper to follow call order and improve readability. r=android-reviewers,marcin,alastun

Comment 8

[twhite (OOO 3rd July - 10th July)]

Attachment: Bug 2047849 - Part 1: Remove the shouldShowElevation parameter and use the existing isSmall flag for gating logic instead.

Original Revision: https://phabricator.services.mozilla.com/D306940

Comment 9

[twhite (OOO 3rd July - 10th July)]

Attachment: Bug 2047849 - Part 2: Rename the func parameter in toPageUiData to jexlEvaluator for improved clarity.

Original Revision: https://phabricator.services.mozilla.com/D306941

Comment 10

[twhite (OOO 3rd July - 10th July)]

Attachment: Bug 2047849 - Part 3: Reorder toPageUiData parameters to group JEXL-related parameters together.

Original Revision: https://phabricator.services.mozilla.com/D306942

Comment 11

[twhite (OOO 3rd July - 10th July)]

Attachment: Bug 2047849 - Part 4: Hoist the manufacturer check out of toPageUiData, reducing complexity and allowing removal of the LongParameterList suppression.

Original Revision: https://phabricator.services.mozilla.com/D306943

Comment 12

[twhite (OOO 3rd July - 10th July)]

Attachment: Bug 2047849 - Part 5: Reorder private functions in OnboardingMapper to follow call order and improve readability.

Original Revision: https://phabricator.services.mozilla.com/D306944

Comment 13

[twhite (OOO 3rd July - 10th July)]

Attachment: Bug 2047849 - Part 1: Remove the shouldShowElevation parameter and use the existing isSmall flag for gating logic instead.

Original Revision: https://phabricator.services.mozilla.com/D306940

Comment 14

[twhite (OOO 3rd July - 10th July)]

Attachment: Bug 2047849 - Part 2: Rename the func parameter in toPageUiData to jexlEvaluator for improved clarity.

Original Revision: https://phabricator.services.mozilla.com/D306941

Comment 15

[twhite (OOO 3rd July - 10th July)]

Attachment: Bug 2047849 - Part 3: Reorder toPageUiData parameters to group JEXL-related parameters together.

Original Revision: https://phabricator.services.mozilla.com/D306942

Comment 16

[twhite (OOO 3rd July - 10th July)]

Attachment: Bug 2047849 - Part 4: Hoist the manufacturer check out of toPageUiData, reducing complexity and allowing removal of the LongParameterList suppression.

Original Revision: https://phabricator.services.mozilla.com/D306943

Comment 17

[twhite (OOO 3rd July - 10th July)]

Attachment: Bug 2047849 - Part 5: Reorder private functions in OnboardingMapper to follow call order and improve readability.

Original Revision: https://phabricator.services.mozilla.com/D306944

Comment 18

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/640f9fea8c59
https://hg.mozilla.org/mozilla-central/rev/1fd1bb50cbc8
https://hg.mozilla.org/mozilla-central/rev/2df45d84bb96
https://hg.mozilla.org/mozilla-central/rev/d00648aa23f5
https://hg.mozilla.org/mozilla-central/rev/6b6907f350cb

Comment 19

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/89f3da33093b
https://hg.mozilla.org/releases/mozilla-beta/rev/467cfeb47915
https://github.com/mozilla-firefox/firefox/commit/ea963c97d6a8
https://hg.mozilla.org/releases/mozilla-beta/rev/f4f359a5546d
https://github.com/mozilla-firefox/firefox/commit/c734fa4bba54
https://hg.mozilla.org/releases/mozilla-beta/rev/5d98b31a4bf2
https://github.com/mozilla-firefox/firefox/commit/ee601cb8a6cb
https://hg.mozilla.org/releases/mozilla-beta/rev/198c44beb7c2
https://github.com/mozilla-firefox/firefox/commit/adca2644c732
https://hg.mozilla.org/releases/mozilla-beta/rev/1bf41a372280

Comment 20

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/68719db51f18
https://hg.mozilla.org/releases/mozilla-release/rev/48095ddac6f9
https://github.com/mozilla-firefox/firefox/commit/b486479cca89
https://hg.mozilla.org/releases/mozilla-release/rev/f9d97f393c58
https://github.com/mozilla-firefox/firefox/commit/349245a0a6a0
https://hg.mozilla.org/releases/mozilla-release/rev/b82540fc2774
https://github.com/mozilla-firefox/firefox/commit/ad9ebc1e965d
https://hg.mozilla.org/releases/mozilla-release/rev/e519a6f8f002
https://github.com/mozilla-firefox/firefox/commit/7ad8c35c5915
https://hg.mozilla.org/releases/mozilla-release/rev/3c28a4aad17c