2047933 - [Homepage Sports Widget] [phase3] Fix the flash in the sports widget when displaying a third place champions card and a finals card in the pager

Status: VERIFIED FIXED

(Firefox for Android :: Homepage, defect)

Description

[Moyin [:moyin]]

Steps to reproduce

1. Enable the Sports Widget
2. Using the mockwebserver, advance the tournament to the finals stage
3. Launch the app from a cold start

Expected behavior

The Keep tabs card is displayed briefly, and then the Finals card is displayed.

Actual behavior

The Keep tabs card is displayed briefly, then the Third place card, then the Finals card

Comment 1

[Moyin [:moyin]]

Attachment: Bug 2047933 - Fix the flash in the sports widget when displaying a third place champions card and a finals card in the pager

Comment 2

[[:skhan]]

Attachment: Bug 2047933 - Fix the flash in the sports widget when displaying a third place champions card and a finals card in the pager

Before:
{F72832951}

After:
{F72833040}

Original Revision: https://phabricator.services.mozilla.com/D306976

Comment 3

[[:skhan]]

Attachment: Bug 2047933 - Fix the flash in the sports widget when displaying a third place champions card and a finals card in the pager

Before:
{F72832951}

After:
{F72833040}

Original Revision: https://phabricator.services.mozilla.com/D306976

Comment 4

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Two sports-widget pager issues remain during the tournament:
• Bug 2047473 — the pager doesn't open on the most relevant match (live, else next upcoming) and reorders cards unintuitively (live/finals pinned out of date order); it also doesn't keep the user's swiped page when returning via a new tab.
• Bug 2047933 — a visible flash/flicker when the celebration cards appear at tournament end (the "keep tabs → champions → finals" transition).
  Both are user-facing during exactly the moments the widget matters most.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: Verify: the pager opens on the live match (or next upcoming; the Final/champion once the tournament is over); the swiped page is preserved across a new tab / config change and resets to live only after the app is killed; and there's no flash when the third-place/finals cards appear.
• Risk associated with taking this patch: low
• Explanation of risk level: Confined to the sports-widget pager — card ordering in MatchCardBuilder, the open-on page in sportsCardPages, and PagerState seeding/keying in SportsCardPager. It can't affect anything outside the widget, and the widget is gated behind the World Cup feature. 2047933 only changes when the pager state is recreated (on card-set identity change), removing a transient frame.
• String changes made/needed?: No
• Is Android affected?: yes

Comment 5

[Phabricator Automation]

firefox-release Uplift Approval Request

• User impact if declined/Reason for urgency: Two sports-widget pager issues remain during the tournament:
• Bug 2047473 — the pager doesn't open on the most relevant match (live, else next upcoming) and reorders cards unintuitively (live/finals pinned out of date order); it also doesn't keep the user's swiped page when returning via a new tab.
• Bug 2047933 — a visible flash/flicker when the celebration cards appear at tournament end (the "keep tabs → champions → finals" transition).
  Both are user-facing during exactly the moments the widget matters most.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: Verify: the pager opens on the live match (or next upcoming; the Final/champion once the tournament is over); the swiped page is preserved across a new tab / config change and resets to live only after the app is killed; and there's no flash when the third-place/finals cards appear.
• Risk associated with taking this patch: low
• Explanation of risk level: Confined to the sports-widget pager — card ordering in MatchCardBuilder, the open-on page in sportsCardPages, and PagerState seeding/keying in SportsCardPager. It can't affect anything outside the widget, and the widget is gated behind the World Cup feature. 2047933 only changes when the pager state is recreated (on card-set identity change), removing a transient frame.
• String changes made/needed?: No
• Is Android affected?: yes

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7e7c5b1e47cd
https://hg.mozilla.org/integration/autoland/rev/606a98d87c08
Fix the flash in the sports widget when displaying a third place champions card and a finals card in the pager r=android-reviewers,skhan

Comment 7

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/b95546c0ef72
https://hg.mozilla.org/releases/mozilla-beta/rev/dfdc2526fbca

Comment 8

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/606a98d87c08

Comment 9

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: Recording_20260617_171413.mp4

This issue is verified as fixed on Firefox for Android Nightly 154 (2026-06-17) using Samsung S24 Ultra (Android 16) and Google Pixel 10 Pro (Android 16). The final cards are correctly displayed after restarting the browser.

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/754b95fea6be
https://hg.mozilla.org/releases/mozilla-release/rev/3fdce6adf65e

Comment 11

[Mira Lobontiu (Android QA)]

Verified as implemented also on Beta 153.0b1 build 2, and on RC 152.0.1 Firefox for Android: the "Bronze final" card, then the "Final" card are displayed.
Tested with a Pixel 6 (Android 17).