Update fluent strings for Settings pane headers that use message references
Categories
(Firefox :: Settings UI, enhancement)
Tracking
()
People
(Reporter: akulyk, Assigned: akulyk)
References
Details
(Whiteboard: [recomp])
Attachments
(4 files)
|
86.45 KB,
image/png
|
Details | |
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-beta+
|
Details | Review |
|
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-release+
|
Details | Review |
Some Settings pane headers (Languages, AI controls, and Downloads) reference the navbar strings instead of defining their own messages.
Fluent message references (e.g. { message-id }) have no fallback: if the referenced message isn't translated in the active locale, the reference itself is rendered as literal text rather than the source-locale value.
Fix: Give these three headers their own dedicated Fluent strings. Include fluent migration so existing translations of the referenced navbar strings are carried over to the new header strings, avoiding re-translation work across locales.
Updated•7 days ago
|
Comment 5•5 days ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined/Reason for urgency: For the languages that still don't have translations for the new settings strings (e.g., Ukrainian) some Settings page headers display message reference ( like { pane-languages-title2 } ) instead of actual strings.
- Code covered by automated testing?: no
- Fix verified in Nightly?: yes
- Needs manual QE testing?: yes
- Steps to reproduce for manual QE testing: Manual testing is tricky as we can't change browser language in Nightly, but when navigating to about:preferences#downloads, about:preferences#languages or about:preferences#ai, the page should display it's actual header string.
- Risk associated with taking this patch: low
- Explanation of risk level: Only changes the strings
- String changes made/needed?: 3 strings where changed and migration was provided
- Is Android affected?: no
Original Revision: https://phabricator.services.mozilla.com/D307105
Updated•5 days ago
|
Updated•5 days ago
|
Original Revision: https://phabricator.services.mozilla.com/D307105
Updated•4 days ago
|
Comment 9•4 days ago
|
||
firefox-release Uplift Approval Request
- User impact if declined/Reason for urgency: For the languages that still don't have translations for the new settings strings (e.g., Ukrainian and ~90 other locales) some Settings page headers display message reference ( like { pane-languages-title2 } ) instead of actual strings.
- Code covered by automated testing?: no
- Fix verified in Nightly?: yes
- Needs manual QE testing?: yes
- Steps to reproduce for manual QE testing: Manual testing is tricky as we can't change browser language in Nightly, but when navigating to about:preferences#downloads, about:preferences#languages or about:preferences#ai, the page should display it's actual header string.
- Risk associated with taking this patch: low
- Explanation of risk level: Only changes the strings
- String changes made/needed?: 3 strings where changed and migration was provided. Localization team confirmed they are OK with uplifting this change
- Is Android affected?: no
Updated•4 days ago
|
Updated•4 days ago
|
Comment 10•4 days ago
|
||
This issue does not reproduce on the Russion build, but it does reproduce on the Ukranian build (Nightly v154.0a1 20260616140050).
The following incorrect titles can be observed: {pane-downloads-title2}, {pane-languages-title2}, {pane-ai-controls-title2}.
I can confirm the fix in Nightly v154.0a1 20260618200449.
The correct section titles are displayed: Downloads, Languages, AI controls.
The issue still reproduces in the latest live Beta v153.0b1 (build2) and verification will be performed after v153.0b2 will be released.
Updated•3 days ago
|
Updated•3 days ago
|
Comment 11•3 days ago
|
||
| uplift | ||
Comment 13•1 day ago
|
||
This fix is also confirmed in Beta 153.0b2; The correct section titles are displayed: Downloads, Languages, AI controls.
Tested in MacOS 14, Windows 10 and Ubuntu 24.
Description
•