Closed Bug 2047983 Opened 7 days ago Closed 5 days ago

Update fluent strings for Settings pane headers that use message references

Categories

(Firefox :: Settings UI, enhancement)

Desktop
All
enhancement

Tracking

()

VERIFIED FIXED
154 Branch
Tracking Status
relnote-firefox --- 152+
firefox152 + fixed
firefox153 + verified
firefox154 + verified

People

(Reporter: akulyk, Assigned: akulyk)

References

Details

(Whiteboard: [recomp])

Attachments

(4 files)

Some Settings pane headers (Languages, AI controls, and Downloads) reference the navbar strings instead of defining their own messages.

Fluent message references (e.g. { message-id }) have no fallback: if the referenced message isn't translated in the active locale, the reference itself is rendered as literal text rather than the source-locale value.

Fix: Give these three headers their own dedicated Fluent strings. Include fluent migration so existing translations of the referenced navbar strings are carried over to the new header strings, avoiding re-translation work across locales.

Assignee: nobody → akulyk
Pushed by akulyk@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/ba7364df7bc3 https://hg.mozilla.org/integration/autoland/rev/955d57054853 Update fluent strings for Settings pane headers that use message references r=fluent-reviewers,hjones,bolsson
Status: NEW → RESOLVED
Closed: 5 days ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: For the languages that still don't have translations for the new settings strings (e.g., Ukrainian) some Settings page headers display message reference ( like { pane-languages-title2 } ) instead of actual strings.
  • Code covered by automated testing?: no
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: yes
  • Steps to reproduce for manual QE testing: Manual testing is tricky as we can't change browser language in Nightly, but when navigating to about:preferences#downloads, about:preferences#languages or about:preferences#ai, the page should display it's actual header string.
  • Risk associated with taking this patch: low
  • Explanation of risk level: Only changes the strings
  • String changes made/needed?: 3 strings where changed and migration was provided
  • Is Android affected?: no
Attachment #9598857 - Flags: approval-mozilla-beta?
Flags: qe-verify+
Attachment #9598857 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9598931 - Flags: approval-mozilla-release?

firefox-release Uplift Approval Request

  • User impact if declined/Reason for urgency: For the languages that still don't have translations for the new settings strings (e.g., Ukrainian and ~90 other locales) some Settings page headers display message reference ( like { pane-languages-title2 } ) instead of actual strings.
  • Code covered by automated testing?: no
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: yes
  • Steps to reproduce for manual QE testing: Manual testing is tricky as we can't change browser language in Nightly, but when navigating to about:preferences#downloads, about:preferences#languages or about:preferences#ai, the page should display it's actual header string.
  • Risk associated with taking this patch: low
  • Explanation of risk level: Only changes the strings
  • String changes made/needed?: 3 strings where changed and migration was provided. Localization team confirmed they are OK with uplifting this change
  • Is Android affected?: no
QA Whiteboard: [uplift][qa-ver-needed-c154/b153]

This issue does not reproduce on the Russion build, but it does reproduce on the Ukranian build (Nightly v154.0a1 20260616140050).
The following incorrect titles can be observed: {pane-downloads-title2}, {pane-languages-title2}, {pane-ai-controls-title2}.

I can confirm the fix in Nightly v154.0a1 20260618200449.
The correct section titles are displayed: Downloads, Languages, AI controls.

The issue still reproduces in the latest live Beta v153.0b1 (build2) and verification will be performed after v153.0b2 will be released.

Attachment #9598931 - Flags: approval-mozilla-release? → approval-mozilla-release+

Added to the 152.0.2 relnotes.

This fix is also confirmed in Beta 153.0b2; The correct section titles are displayed: Downloads, Languages, AI controls.
Tested in MacOS 14, Windows 10 and Ubuntu 24.

Status: RESOLVED → VERIFIED
QA Whiteboard: [uplift][qa-ver-needed-c154/b153] → [uplift][qa-ver-done-c154/b153]
Flags: qe-verify+
OS: Unspecified → All
Hardware: Unspecified → Desktop
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: