Closed
Bug 2048016
Opened 21 days ago
Closed 18 days ago
[Google Lens] Update API endpoint and parameters per new Google spec
Categories
(Firefox for Android :: Search, task)
Tracking
()
RESOLVED
FIXED
154 Branch
People
(Reporter: harrisono, Assigned: harrisono)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid][group3])
Attachments
(2 files)
|
48 bytes,
text/x-phabricator-request
|
Details | Review | |
|
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-beta+
|
Details | Review |
No description provided.
|
Assignee | |
Updated•21 days ago
|
Assignee: nobody → hoglesby
Status: NEW → ASSIGNED
Whiteboard: [fxdroid][group3]
|
||
Updated•21 days ago
|
|
|
Assignee | |
Comment 1•21 days ago
|
||
Pushed by hoglesby@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/bd8365e277dc
https://hg.mozilla.org/integration/autoland/rev/d9f796a24946
Update API endpoint and parameters for Google Lens on Fenix r=android-reviewers,Roger
|
||
Comment 3•18 days ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 18 days ago
status-firefox154:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
|
|
||
Comment 4•18 days ago
|
||
| bugherder | ||
|
||
Comment 5•15 days ago
|
||
firefox-beta Uplift Approval Request
- User impact if declined/Reason for urgency: Users' Google Lens searches will not be sent with all proper attribution.
- Code covered by automated testing?: yes
- Fix verified in Nightly?: yes
- Needs manual QE testing?: no
- Steps to reproduce for manual QE testing:
- Risk associated with taking this patch: low
- Explanation of risk level: Low risk patch, this feature is still in limited experiment in beta.
- String changes made/needed?: no
- Is Android affected?: yes
Attachment #9599976 -
Flags: approval-mozilla-beta?
|
|
Assignee | |
Comment 6•15 days ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D307083
|
|
||
Updated•14 days ago
|
Attachment #9599976 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
|
||
Updated•14 days ago
|
status-firefox153:
--- → fixed
|
|
Assignee | |
Comment 8•7 days ago
|
||
Further context for future reference:
This patch was necessary to implement the new parameters set by the Google partnership team as well as use the "upload by bytes" method that Google prefers us to use for this feature.
"upload by url" method still exists as a fallback.
You need to log in
before you can comment on or make changes to this bug.
Description
•