Rename isIPProtectionEnabled to overrideIPProtectionEnabled in Settings.kt
Categories
(Firefox for Android :: Privacy, task)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox162 | --- | verified |
People
(Reporter: jonalmeida, Assigned: segun)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid] [android-activation-trust])
Based on the code review here we want to do this rename eventually but not today as we're about to ship code and naming refactors make it hard to uplift changes, if and when needed.
We should not rename the pref key because it has a persistent value which will reset existing users state.
Updated•5 months ago
|
| Reporter | ||
Updated•2 months ago
|
| Assignee | ||
Updated•11 days ago
|
Comment 2•11 days ago
|
||
| bugherder | ||
Comment 3•10 days ago
•
|
||
Verified on Fx Nightly 162.0a1 (Build # 2016194679), Google Pixel 7A, Android 16, region RO.
On Nightly the built-in VPN is shown by default, so the Secret Settings "Enable IP Protection UI" switch has no visible effect while no experiment is enrolled.
With "VPN - Android Phase 0 Holdback 155" (control: ip-protection.enabled = false, treatment-a: ip-protection.enabled = true):
- Control, switch off: VPN hidden.
- Control, switch on: VPN shown.
- Control, switch on, then Firefox restarted: VPN still shown.
- Control, switch off, then Firefox restarted: VPN hidden. (here the results varied, if the switch was on then off, because of restarting the app multiple times, the experiment disappeared from the nimbus list and the VPN was shown)
- Treatment A, switch off: VPN hidden. RO is not in treatment A's allowed regions, so the region check hides it. If Region is changed to US for example the VPN was shown.
- Treatment A, switch on: VPN shown.
- Treatment A, switch on, then Firefox restarted: VPN still shown.
- Treatment A, switch off, then Firefox restarted: VPN was shown even if region was RO. (here is one of the cases where the experiment disappearred after restarting the app)
Note: Enrollment changes did not take effect reliably without clearing app data. And occasionally the experiment disappeared from the nimbus list and the results were not reliable, so clearing the app data multiple times was necessary since it resets the Secret Settings switch and the experiment enrollment.
(video)
Segun is there anything else you think we can check? Thanks!
Updated•10 days ago
|
| Assignee | ||
Comment 4•9 days ago
|
||
(In reply to Alexandra Martin [:alemartin], FxA/SubPlat/VPN QA from comment #3)
Segun is there anything else you think we can check? Thanks!
Thank you so much. I think this is pretty exhaustive, and nothing else remains. This change is also not supposed to have any impact, which sounds like what your test also confirmed.
Thanks.
Updated•6 days ago
|
Description
•