2048048 - Policies interactions with the new settings UI for Firefox Home

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect, P3)

Description

[Mike Kaply [:mkaply] (PTO until Sept 14)]

Running into a few issues with the new settings UI and policies:

1. Weather isn't locked.
2. Turning off stories makes it go away completely.
3. The new "Support Firefox" checkbox flips the checkboxes underneath it even when the are disabled.

I'm honestly not sure what to do about the support Firefox checkbox. I think it should be disable if sponsored stories and sponsored shortcuts are disabled?

Comment 1

[Mike Kaply [:mkaply] (PTO until Sept 14)]

Attachment: Bug 2048048 - Fix policy issues with new tab preferences. r?jmendez

Comment 2

[Mike Kaply [:mkaply] (PTO until Sept 14)]

I'm honestly not sure what to do about the support Firefox checkbox. I think it should be disable if sponsored stories and sponsored shortcuts are disabled?

I added some custom code that does the right thing based on the checkboxes.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cf46b7382184
https://hg.mozilla.org/integration/autoland/rev/9cbe92ad5fa8
Fix policy issues with new tab preferences. r=jmendez

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a3455aa89429
https://hg.mozilla.org/integration/autoland/rev/43f808f25023
Revert "Bug 2048048 - Fix policy issues with new tab preferences. r=jmendez" for causing gtest failures.

Comment 5

[agoloman]

Backed out for causing gtest failures.

• Backout link
• Push with failures
• Failure Log

Comment 6

[agoloman]

Relanded because it was not the cause.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ba7f1e692798
https://hg.mozilla.org/integration/autoland/rev/1cb005f007a2
Fix policy issues with new tab preferences. r=jmendez

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d890576dc1fc
https://hg.mozilla.org/integration/autoland/rev/06289060f0a0
Revert "Bug 2048048 - Fix policy issues with new tab preferences. r=jmendez" for causing mochitest plain failures @test_bug1268962.html.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/73815c686dca
https://hg.mozilla.org/integration/autoland/rev/8aaae62398da
Fix policy issues with new tab preferences. r=jmendez

Comment 10

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/8aaae62398da

Comment 11

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Policy. Want for 153 ESR.
  Also, broken prefs policy right now.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Policy only.
• String changes made/needed?: None
• Is Android affected?: no

Comment 12

[Mike Kaply [:mkaply] (PTO until Sept 14)]

Attachment: Bug 2048048 - Fix policy issues with new tab preferences.

Original Revision: https://phabricator.services.mozilla.com/D307332

Comment 13

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/a339736ad211
https://hg.mozilla.org/releases/mozilla-beta/rev/29a1c67c2855