Closed Bug 2048098 Opened 5 months ago Closed 4 months ago

Firefox no longer starting in Maximized state as desired

Categories

(Core :: Widget: Win32, defect)

Firefox 152
defect

Tracking

()

RESOLVED INVALID

People

(Reporter: ecm_moz, Unassigned)

Details

Attachments

(2 files)

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:152.0) Gecko/20100101 Firefox/152.0

Steps to reproduce:

With v152.0, Firefox is no longer starting in Maximized state as desired but rather in the Restored state, despite (1) my Windows toolbar shortcut's Run: Maximized setting and (2) having closed FF in the Maximized state (i.e., via session memory).
Some details (attn. Greg Stoll:

  • I'm running Windows 10 Home v10.0.19045 Build 19045.
  • My taskbar short uses the Run option set to Maximized (see attached screen shot), not something on the command line. (Is there a maximized command-line switch? If so, I could try that as well.)
  • When I quit Firefox, it's in the Maximized state but not fullscreen.
  • When I start Firefox, it's in the Restored state, with the window taking up roughly 2/3 of the screen horizontally and vertically.

Actual results:

FF opened in the Restored state.

Expected results:

FF should have opened Maximized, as it had been before v152.0 (i.e., in v151.0.4).

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Win32' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Widget: Win32
Product: Firefox → Core

:jaas, Bug 1701109 might be a potential regressor here?

Flags: needinfo?(jaas)

I suppose it's possible but I'm not sure how it would be causing this. I don't see other obvious culprits though. It would be very helpful if the reporter could use mozregression to narrow it down:

https://github.com/mozilla/mozregression/releases

https://blog.nightly.mozilla.org/2017/06/07/using-mozregression-on-windows/

Flags: needinfo?(jaas)

(In reply to Josh Aas from comment #3)

I suppose it's possible but I'm not sure how it would be causing this. I don't see other obvious culprits though. It would be very helpful if the reporter could use mozregression to narrow it down:

Alas, my environment here doesn't really lend itself to using mozregression. I can tell you, though, that in v151.0.4 FF was opening Maximized (albeit missing the title bar; see Bug 2010302), whereas in v152.0 it now opens Restored. That should narrow it down a little. I believe there was an intervening Patch Tuesday, but let's hope that wasn't a factor!

Perhaps some lingering PreXULSkeletonUI issue?

No worries. I'll see if I can reproduce your issue on my Windows machine and run mozregression there, but it'll take me a couple of days.

I tried to reproduce this today (Windows 11), but I can't get the behavior you want to reproduce with Firefox 149 or 152. If I make a taskbar shortcut and set it to run as maximized, it still always just starts Firefox with the window however it was when Firefox was last closed. Same behavior for both versions. Edge behaves the same way as Firefox, setting run as maximized seems to have no effect.

I would expect Firefox (and Edge) to start with a maximized window no matter what when that option is set. Seems like I just don't understand what that run as maximized option is supposed to do?

I'm on Linux, and Firefox hasn't restarted in Maximized state for a while now. I'm on version 151.0.4 (64-bit). I'd like to have FF remember the previous window state across quit/relaunch, or else have a "--maximized" CLI option to force maximize at launch.

(In reply to Josh Aas from comment #6)

I tried to reproduce this today (Windows 11), but I can't get the behavior you want to reproduce with Firefox 149 or 152. If I make a taskbar shortcut and set it to run as maximized, it still always just starts Firefox with the window however it was when Firefox was last closed.

In addition to my shortcut, I always close FF in the Maximized state ... and it opens Restored nonetheless. I would be happy if it still honored either attempt.

My suspicion remains that it might have something to do with the recent fix for the missing title bar issue.

@ecm

  • What do the registry keys say now (from bug 2010302)?
  • Does this issue happen if you run in a new profile? (Use Preferences or about:profiles, or run Firefox with the -P argument, to create one.)
  • Does this happen if you run in troubleshooting mode (Help > Troubleshoot Mode > Restart)?
Flags: needinfo?(ecm_moz)
Severity: -- → S4

(In reply to David Parks [:handyman] from comment #9)

@ecm

  • What do the registry keys say now (from bug 2010302)?

Computer\HKEY_CURRENT_USER\Software\Mozilla\Firefox\PreXULSkeletonUISettings values (all in hex):
...|Height = 289
...|Width = 3f8
...|ScreenX = f
...|ScreenY = 6
...|Maximized = 1

  • Does this issue happen if you run in a new profile? (Use Preferences or about:profiles, or run Firefox with the -P argument, to create one.)

No. (But I get no title bar -- perhaps to be expected for a brand-new profile?)

After closing FF and restarting, I realized I was still using the test profile, so I changed it back to Default, closed, and restarted; it came up Maximized but without the title bar. Thinking perhaps my setting in "Customize toolbars" had somehow been lost, I went back to Preferences only to find it still set to show the title bar. I toggled the value off and back on, clicked Done, and restarted FF. Result: I had the title bar again but it was back to opening in Restored, not Maximized. Seems I can't have both!

  • Does this happen if you run in troubleshooting mode (Help > Troubleshoot Mode > Restart)?

Yes. (Displaying no menu bar, interestingly.)

Flags: needinfo?(ecm_moz)

This is extremely helpful information, thanks.

Can you collect another log the way that you did in bug 2010302? The difference after that patch probably pinpoints the issue.

Also, on the registry, the list you added was either incomplete or there's been some corruption. Can you check that you additionally have the following key suffixes (from the list here):

  • Enabled
  • UrlbarCSSSpan
  • CssToDevPixelScaling
  • SearchbarCSSSpan
  • SpringsCSSSpan
  • Theme
  • Flags
  • Progress (seems to be optional)

Missing keys could be the issue. You may have deleted them when looking at the other bug. Either way, the log should help if this doesn't.

Flags: needinfo?(ecm_moz)

Also posting or emailing your about:support might highlight any prefs that are overriding behavior that might have gotten toggled. It working in troubleshooting mode suggests this as the culprit.

(In reply to David Parks [:handyman] from comment #12)

Also posting or emailing your about:support might highlight any prefs that are overriding behavior that might have gotten toggled.

Hmm, that's quite a lot of data. Would you perhaps be interested in the Important Modified Preferences, Important Locked Preferences, and Add-ons sections only/primarily?

I'll get to work on the other stuff later. Meanwhile, note that I do have all the other Registry keys you cited; it's just that they weren't mentioned in the original set of relevant ones for bug 2010302, so I didn't include them above. Is their existence enough, or do you also want their values?

As I recall, the last time I tried creating such a log (after the release of v152.0), even from an Administrative command prompt, the result was a zero-byte file ... but I'll give it another shot.

Flags: needinfo?(ecm_moz)

(In reply to ecm from comment #13)

Hmm, that's quite a lot of data. Would you perhaps be interested in the Important Modified Preferences, Important Locked Preferences, and Add-ons sections only/primarily?

The "Copy text to clipboard" button is the easiest way to include the support data.

I'll get to work on the other stuff later. Meanwhile, note that I do have all the other Registry keys you cited; it's just that they weren't mentioned in the original set of relevant ones for bug 2010302, so I didn't include them above. Is their existence enough, or do you also want their values?

No, the key presence was the theory. It was a long shot given that troubleshooting worked. The prefs are a bit more likely, but since it worked before and you presumably didn't change any prefs yourself, they are also just a maybe.

(In reply to David Parks [:handyman] from comment #14)

(In reply to ecm from comment #13)
The "Copy text to clipboard" button is the easiest way to include the support data.

See attached About_support_excerpt.txt for highlights; let me know if you need more.

I'll get to work on the other stuff later. Meanwhile, note that I do have all the other Registry keys you cited; it's just that they weren't mentioned in the original set of relevant ones for bug 2010302, so I didn't include them above. Is their existence enough, or do you also want their values?

No, the key presence was the theory. It was a long shot given that troubleshooting worked.

Just to be clear, starting in troubleshooting mode did not work. You had asked, "Does this happen if you run in troubleshooting mode (Help > Troubleshoot Mode > Restart)?" and I responded that yes, it (i.e., starting in Restored rather than Maximized) did happen -- along with the menu bar going missing again.

The prefs are a bit more likely, but since it worked before and you presumably didn't change any prefs yourself, they are also just a maybe.

I have changed various of them in the past, but not during the course of this investigation. Still, maybe something I changed way-back-when is a factor now.

(In reply to David Parks [:handyman] from comment #14)

I just tried creating a startup log for you and it once again resulted in a zero-byte file.

(In reply to ecm from comment #15)

Just to be clear, starting in troubleshooting mode did not work. You had asked, "Does this happen if you run in troubleshooting mode (Help > Troubleshoot Mode > Restart)?" and I responded that yes, it (i.e., starting in Restored rather than Maximized) did happen -- along with the menu bar going missing again.

Oops, I meant to say "worked in a new profile".

It looks like you have a lot of prefs set that would do this. You probably set some of them after you last saw this working. privacy.resistFingerprinting, for example, would prevent maximized mode on startup. If turning that off doesn't restore the functionality then you would need to bisect your prefs in about:config to figure it out.

Status: UNCONFIRMED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Ever confirmed: true
Resolution: FIXED → ---

(In reply to David Parks [:handyman] from comment #18)

(In reply to ecm from comment #15)
It looks like you have a lot of prefs set that would do this. You probably set some of them after you last saw this working. privacy.resistFingerprinting, for example, would prevent maximized mode on startup. If turning that off doesn't restore the functionality then you would need to bisect your prefs in about:config to figure it out.

Is there anything like privacy.fingerprintingProtection.overrides but for privacy.resistFingerprinting? I'm quite attached to running Maximized but would otherwise like to retain resistFingerprinting's (as well as fingerprintingProtection's) protections. If so, what would be the about:config syntax for it?

No, there are only overrides for privacy.fingerprintingProtection. privacy.resistFingerprinting is more intense. Unfortunately, if you want to keep it, you'll have to maximize the window manually.

Status: REOPENED → RESOLVED
Closed: 4 months ago → 4 months ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: