Closed Bug 2048127 Opened 2 months ago Closed 2 months ago

[wpt-sync] Sync PR 60672 - Enable WebExtension tests support in wptrunner for Chrome.

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox154 fixed)

Status:
RESOLVED FIXED
Milestone:
154 Branch
Tracking Flags:
Tracking Status
firefox154 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 60672 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/60672
Details from upstream follow.

justinlulejian <justinlulejian@users.noreply.github.com> wrote:

Enable WebExtension tests support in wptrunner for Chrome.

Before this change, wptrunner did not support running WebExtension tests for Chrome. It didn't have the ability to detect extension tests and apply necessary Chrome flags (like enabling the extension test API on webpages).

Additionally, the WebDriver BiDi extension installation/uninstallation implementation in wptrunner was incorrect. self.webdriver refers to the Session object instead of the WebDriverBidiProtocol object, which contains the loop() method. Also install() and uninstall() methods expect keyword arguments, not positional arguments.

After this change, wptrunner should be able to run WebExtension tests. It detects them based on path and applies Chrome flags that enable the (chrome|browser).test JS API. The WebDriver BiDi implementation is also updated to use the expected keyword parameters and WebDriverBidiProtocol loop.

Context: crbug.com/493946943

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues

The PR was not expected to affect any tests, but the try push wasn't a success. Check the try results for infrastructure issues

Pushed by wptsync@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/381b352c4595 https://hg.mozilla.org/integration/autoland/rev/62a1f7fb2491 [wpt PR 60672] - Enable WebExtension tests support in wptrunner for Chrome., a=testonly

Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/62a1f7fb2491

Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox154: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
You need to log in before you can comment on or make changes to this bug.