2048149 - Containers: update nova colors

Status: ASSIGNED

(Firefox :: Containers, task)

Comment 1

[Andrea Marchesini [:baku]]

Attachment: Bug 2048149 - Containers: update nova colors & styles

Comment 2

[Andrea Marchesini [:baku]]

Attachment: Bug 2048149 - Containers style update - part 1 - CSS variables and colors, r?emilio

Comment 3

[Andrea Marchesini [:baku]]

Attachment: Bug 2048149 - Containers style update - part 3 - common icon pattern

Comment 4

[Andrea Marchesini [:baku]]

Attachment: Bug 2048149 - Containers style update - part 2 - fix color picker, r?emilio

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/17d1c551aa4f
https://hg.mozilla.org/integration/autoland/rev/d1f37566e4ea
Containers style update - part 1 - CSS variables and colors, r=emilio

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d6d368a45d1a
https://hg.mozilla.org/integration/autoland/rev/92de21d6b335
Revert "Bug 2048149 - Containers style update - part 1 - CSS variables and colors, r=emilio" for causing xpcshell failures in test_ext_contextual_identities.js.

Comment 7

[Serban Stanca [:SerbanS]]

Reverted this because it was causing xpcshell failures in test_ext_contextual_identities.js.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | xpcshell-remote.toml:toolkit/components/extensions/test/xpcshell/test_ext_contextual_identities.js | test_contextualIdentity_color_aliases_api - [test_contextualIdentity_color_aliases_api : 142] nova on: the same container returns the refreshed code - Expected: #4cc4e1, Actual: #10a4ca - false == true

P.S. Please also check this.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e34aee9f1114
https://hg.mozilla.org/integration/autoland/rev/f5fe70249b4f
Containers style update - part 1 - CSS variables and colors, r=emilio

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d69a41d20596
https://hg.mozilla.org/integration/autoland/rev/33f14361b940
Revert "Bug 2048149 - Containers style update - part 1 - CSS variables and colors, r=emilio" for causing mochitests failures in browser_parsable_css.js.

Comment 10

[Serban Stanca [:SerbanS]]

Reverted this because it was causing mochitests failures in browser_parsable_css.js.

• Revert link
• Push with failures
• Failure Log
• Failure line: TEST-UNEXPECTED-FAIL | browser/base/content/test/static/browser_parsable_css.js | checkAllTheCSS - custom property --identity-picker-color is not referenced

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2c348757b6bc
https://hg.mozilla.org/integration/autoland/rev/271018ab17b7
Containers style update - part 1 - CSS variables and colors, r=emilio

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3f0a76a52d49
https://hg.mozilla.org/integration/autoland/rev/b53abafc73d0
Containers style update - part 2 - fix color picker, r=emilio,desktop-theme-reviewers

Comment 13

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/271018ab17b7
https://hg.mozilla.org/mozilla-central/rev/b53abafc73d0